From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19046 invoked by alias); 19 Sep 2007 19:46:58 -0000 Received: (qmail 19030 invoked by uid 22791); 19 Sep 2007 19:46:57 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Sep 2007 19:46:47 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 36FDF98298; Wed, 19 Sep 2007 19:46:46 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 1786A98152; Wed, 19 Sep 2007 19:46:46 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IY5VU-0002nM-Pa; Wed, 19 Sep 2007 15:46:44 -0400 Date: Wed, 19 Sep 2007 19:46:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA] "etext/_etext" may be missing, add configure check Message-ID: <20070919194644.GA10542@caradoc.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20070919193448.GA15629@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070919193448.GA15629@adacore.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00259.txt.bz2 On Wed, Sep 19, 2007 at 12:34:48PM -0700, Joel Brobecker wrote: > I propose to add a check in configure for "etext", and then > change the above to define TEXTEND only if at least either of > the etext symbol is defined. Then we can add the definition of > TEXT to the conditionalization that decides whether or not to > include the profiling functionality. Sure. > On a side-note, I also think that --enable-profiling=no should > have deactivated this code as well, but that's a different thread. I don't. That's supposed to disable automatic profiling and compiling with -pg, not the manual profiling commands. > 2007-09-19 Joel Brobecker > > * configure.ac: Add check for "etext". > * configure, config.in: Regenerate. > * maint.c (TEXTEND): Only define if either _etext or etext > are available. > Disable the profiling functionality if TEXTEND is not defined. OK. > This was tested on x86-linux, without any regressions. On LynxOS, it > allows me to complete the GDB build (although it's a dummy GDB at this > point, since my primary interest is in the gdbserver). You don't need this, by the way. Unlike the gdb subdirectory, the gdb/gdbserver subdirectory is standalone. You need the whole source tree but you can run src/gdb/gdbserver/configure directly. This should be in the manual, or at least the README. -- Daniel Jacobowitz CodeSourcery