From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20491 invoked by alias); 19 Sep 2007 13:16:54 -0000 Received: (qmail 20482 invoked by uid 22791); 19 Sep 2007 13:16:53 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Sep 2007 13:16:43 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 922B698298; Wed, 19 Sep 2007 13:16:41 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 713DE98152; Wed, 19 Sep 2007 13:16:41 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IXzQ0-0007bQ-Nf; Wed, 19 Sep 2007 09:16:40 -0400 Date: Wed, 19 Sep 2007 13:16:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" Subject: Re: mips-tdep.c: Fix sw watchpoint-out-of-scope events Message-ID: <20070919131640.GA29209@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , gdb-patches@sourceware.org, "Maciej W. Rozycki" References: <20070918155400.GA1128@caradoc.them.org> <20070919123827.GA27457@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00251.txt.bz2 On Wed, Sep 19, 2007 at 02:05:02PM +0100, Maciej W. Rozycki wrote: > Well, that sounds reasonable given the complication around getting things > perfect here. Ideally the out-of-scope event should happen at the same > place where "finish" from the function in question would stop; in my > opinion at least. Honestly, I'm not sure we should even be stopping when watchpoints go out of scope. Anyway a patch to accept the call site as a PASS is pre-approved. -- Daniel Jacobowitz CodeSourcery