From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20806 invoked by alias); 18 Sep 2007 15:54:09 -0000 Received: (qmail 20797 invoked by uid 22791); 18 Sep 2007 15:54:08 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Sep 2007 15:54:03 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 5251B98152; Tue, 18 Sep 2007 15:54:01 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 313889810B; Tue, 18 Sep 2007 15:54:01 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IXfOi-0000LL-4v; Tue, 18 Sep 2007 11:54:00 -0400 Date: Tue, 18 Sep 2007 15:54:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" Subject: Re: mips-tdep.c: Fix sw watchpoint-out-of-scope events Message-ID: <20070918155400.GA1128@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , gdb-patches@sourceware.org, "Maciej W. Rozycki" References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00241.txt.bz2 On Tue, Sep 11, 2007 at 05:23:54PM +0100, Maciej W. Rozycki wrote: > This is a fix for software watchpoint-out-of-scope events for MIPS > platforms. It implements a in_function_epilogue_p() hook which is used to > single-step a function's epilogue once a local watchpoint has been > destroyed (because of the restoration of the frame pointer). As a result > the event is only reported once the caller has been reached back. This patch is fine. I wish it wasn't necessary, but for now it is. > for the remote targets. It does not fix them for Linux, because the o32 > calling convention makes the restoration of the GOT pointer in the caller > ("lw gp,..." after "jalr") a part of the function call. Therefore > execution stops in the right function, but one instruction too early, > still within the source line of the call. It is still a step forward > though and less of nuisance for the user. Hmm, do you think we should accept that line as a pass then? The same will happen on other architectures too. -- Daniel Jacobowitz CodeSourcery