Re: [patch] Backtrace prints wrong argument value

Daniel Jacobowitz
2007-09-17T13:15:55Z

On Mon, Sep 17, 2007 at 10:04:38AM -0300, Luis Machado wrote:
> :ADDPATCH PowerPC-64:
>
> Daniel,
>
> Thanks for reviewing.
>
> Yeah, i definitely had issues with my editor and the tabs ended up being
> expanded to spaces. Hopefully this version is correct now. I hope my
> mail client doesn't mess the tabs.

Ouch, this one's even worse. All your tabs were doubled. I've never
seen that happen before.
> @@ -3774,6 +3836,9 @@
> frame_unwind_append_sniffer (gdbarch, dwarf2_frame_sniffer);
> dwarf2_frame_set_adjust_regnum (gdbarch, rs6000_adjust_frame_regnum);
>
> + /* Frame handling. */
> + dwarf2_frame_set_init_reg (gdbarch, ppc_dwarf2_frame_init_reg);
> +
> /* Hook in ABI-specific overrides, if they have been registered. */
> gdbarch_init_osabi (info, gdbarch);
>

Not sure why there's a tab in that - mailer trouble again? Above and
below are indented with only two spaces.

> @@ -3790,6 +3855,7 @@
> tdep->ppc_vr0_regnum = 71;
> tdep->ppc_vrsave_regnum = 104;
> }
> +
> /* Fall Thru */
> case GDB_OSABI_NETBSD_AOUT:
> case GDB_OSABI_NETBSD_ELF:

Stray blank line here.

--
Daniel Jacobowitz
CodeSourcery