From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14600 invoked by alias); 17 Sep 2007 13:15:55 -0000 Received: (qmail 14588 invoked by uid 22791); 17 Sep 2007 13:15:54 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Sep 2007 13:15:45 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id A9C209810B; Mon, 17 Sep 2007 13:15:43 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 54B339810A; Mon, 17 Sep 2007 13:15:43 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IXGRy-0003Md-2E; Mon, 17 Sep 2007 09:15:42 -0400 Date: Mon, 17 Sep 2007 13:15:00 -0000 From: Daniel Jacobowitz To: Luis Machado Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] Backtrace prints wrong argument value Message-ID: <20070917131542.GA12835@caradoc.them.org> Mail-Followup-To: Luis Machado , gdb-patches@sources.redhat.com References: <1177527233.12599.42.camel@localhost> <20070425191304.GA1283@caradoc.them.org> <1179293640.4323.16.camel@localhost> <20070516144250.GD24682@caradoc.them.org> <1189694765.4564.5.camel@localhost> <20070916194510.GC27177@caradoc.them.org> <1190034278.4651.10.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1190034278.4651.10.camel@localhost> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00216.txt.bz2 On Mon, Sep 17, 2007 at 10:04:38AM -0300, Luis Machado wrote: > :ADDPATCH PowerPC-64: > > Daniel, > > Thanks for reviewing. > > Yeah, i definitely had issues with my editor and the tabs ended up being > expanded to spaces. Hopefully this version is correct now. I hope my > mail client doesn't mess the tabs. Ouch, this one's even worse. All your tabs were doubled. I've never seen that happen before. > @@ -3774,6 +3836,9 @@ > frame_unwind_append_sniffer (gdbarch, dwarf2_frame_sniffer); > dwarf2_frame_set_adjust_regnum (gdbarch, rs6000_adjust_frame_regnum); > > + /* Frame handling. */ > + dwarf2_frame_set_init_reg (gdbarch, ppc_dwarf2_frame_init_reg); > + > /* Hook in ABI-specific overrides, if they have been registered. */ > gdbarch_init_osabi (info, gdbarch); > Not sure why there's a tab in that - mailer trouble again? Above and below are indented with only two spaces. > @@ -3790,6 +3855,7 @@ > tdep->ppc_vr0_regnum = 71; > tdep->ppc_vrsave_regnum = 104; > } > + > /* Fall Thru */ > case GDB_OSABI_NETBSD_AOUT: > case GDB_OSABI_NETBSD_ELF: Stray blank line here. -- Daniel Jacobowitz CodeSourcery