From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 888 invoked by alias); 14 Sep 2007 15:40:38 -0000 Received: (qmail 879 invoked by uid 22791); 14 Sep 2007 15:40:38 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Sep 2007 15:40:33 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 853DA982A2; Fri, 14 Sep 2007 15:40:31 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 539939829E; Fri, 14 Sep 2007 15:40:31 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IWDHS-00005j-DH; Fri, 14 Sep 2007 11:40:30 -0400 Date: Fri, 14 Sep 2007 15:40:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" Subject: Re: mi*-watch.exp: Test both hardware and software watchpoints Message-ID: <20070914154030.GA32519@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , gdb-patches@sourceware.org, "Maciej W. Rozycki" References: <20070911161922.GA16571@caradoc.them.org> <20070914142430.GA28551@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00183.txt.bz2 On Fri, Sep 14, 2007 at 04:28:36PM +0100, Maciej W. Rozycki wrote: > Well, I would have thought the destruction of the frame pointer marks the > beginning of the epilogue. Though I can imagine an ABI relaxed enough to > let the compiler shuffle instructions around while optimising so that some > belonging to the body of a function actually arrive past the boundary. Yes, some ABIs are so relaxed. You can't migrate things past moving the stack pointer (interrupts, signals) but the frame pointer is just a convention on a lot of platforms. > > > I don't intend to fix it right now, anyway. And I really do not like > > leaving failing tests. Every few years, I try to reduce the failures > > for a couple of platforms to zero. I'm going to do it again after I > > finish with multi-threaded watchpoints (next week hopefully; patches > > coming this weekend). > > I guess they could act as incentive for platform maintainers. ;-) > > > I think the right fix is going to have to involve GCC. It should emit > > correct unwind info for the epilogue; even without also adding the > > epilogue markers to the line table, correct unwind info will solve > > this problem 99% of the time. > > Fair enough. > > > > + set old_prefix $pf_prefix > > > + set pf_prefix "$pf_prefix $type: " > > > > Is there a double space here? IIUC pf_prefix will be something like > > "gdb.mi/mi-watch.exp: ". > > I would have thought so as well, but the sequence above actually places a > single space character between the variables. Perhaps it is another TCL > feature -- I am not sure if I can be bothered to get to the bottom of it > -- should I? How about a double space after "$type: " in the output? I bet there is: if {[info exists pf_prefix]} { set message [concat $pf_prefix " " $message] } (from dejagnu/framework.exp). > It is not completely bullet-proof, like the whole set of changes anyway, > as for platforms that do not support hw watchpoints at all the tests are > run twice using sw watchpoints and do FAIL for the variation assumed to be > hw. It is not a regression though and a small waste of time only. I can > see whether determining if hw watchpoints are truly available is doable at > some point, but I cannot promise any timeline at the moment. It's quite hard to do. I recommend the use of board files :-) > OK for this bit? Yes, thanks again. -- Daniel Jacobowitz CodeSourcery