From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14669 invoked by alias); 11 Sep 2007 16:19:32 -0000 Received: (qmail 14657 invoked by uid 22791); 11 Sep 2007 16:19:32 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 11 Sep 2007 16:19:25 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 7C53C98308; Tue, 11 Sep 2007 16:19:26 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 5356198101; Tue, 11 Sep 2007 16:19:26 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IV8SQ-0004Zt-NV; Tue, 11 Sep 2007 12:19:22 -0400 Date: Tue, 11 Sep 2007 16:19:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" Subject: Re: mi*-watch.exp: Test both hardware and software watchpoints Message-ID: <20070911161922.GA16571@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , gdb-patches@sourceware.org, "Maciej W. Rozycki" References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00152.txt.bz2 On Tue, Sep 11, 2007 at 04:42:05PM +0100, Maciej W. Rozycki wrote: > The reason for MIPS is (and I suppose for i386 likewise) as soon as the > frame pointer is destroyed in the callee, the watchpoint vanishes. There > is this in_function_epilogue_p() hook that may be used to single-step out > of the function epilogue which is currently not implemented. It isn't generally sufficient, either. It's implemented on PowerPC but the test still fails. The frame pointer is corrupted one instruction before the epilogue is detected, and I couldn't come up with a reasonable way of making it work. > 2007-09-11 Maciej W. Rozycki > > * gdb.mi/mi-watch.exp (test_watchpoint_all): New function. > Move all the tests here and run them twice, once using software > watchpoints and once using hardware watchpoints. > * gdb.mi/mi2-watch.exp (test_watchpoint_all): Likewise. > > OK to apply? In principle, I think so, but give it a day or two to see if anyone objects. How about xfailing the out of scope test for software watchpoints? In practice, there's one problem. You're going to create lots of tests with duplicated test names. The usual way to fix this is to pass a prefix around and apply it everywhere. The clever way to fix this, inspired by Jan's recent change to sepdebug.exp, is to modify the global pf_prefix. If you do that please leave the default prefix present though; save the value at the beginning of the test (i.e. after default_gdb_init) and append to it. -- Daniel Jacobowitz CodeSourcery