Re: [patch 0/1] Threaded Watchpoints

[Daniel Jacobowitz <drow@false.org>]

On Mon, Sep 10, 2007 at 08:22:56PM +0200, Ulrich Weigand wrote:
> Was the change to remove use of HAVE_CONTINUABLE_WATCHPOINTS deliberate?
> It used to be that you had to set one of the three flags in order to
> activate the watchpoint logic at all, but your new code will always
> call STOPPED_BY_WATCHPOINT.

Yes - do you think I shouldn't?  Easy enough to put it back.

> +static void
> +s390_resume (ptid_t ptid, int step, enum target_signal signal)
> +{
> +  if (linux_nat_lwp_is_new (ptid))
> +    s390_fix_watch_points (ptid);
> +  super_resume (ptid, step, signal);
> +}
> 
> This assumes that the new thread's ptid will always be passed to the
> resume.  Is this necessarily the case?  I would expect ptid to be -1
> in most cases ...

It is necessarily the case.  This function is never called through
target_resume, only through linux_nat_resume.  This was one of the big
cleanups that made my patch possible.

> I did a full test on s390-ibm-linux and s390x-ibm-linux, and it works
> fine.  There are no longer any FAILs reported for watchthreads.exp.

Thanks a lot!

-- 
Daniel Jacobowitz
CodeSourcery