From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30920 invoked by alias); 10 Sep 2007 18:23:11 -0000 Received: (qmail 30910 invoked by uid 22791); 10 Sep 2007 18:23:10 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate8.de.ibm.com (HELO mtagate8.de.ibm.com) (195.212.29.157) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Sep 2007 18:23:02 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id l8AIMvRU301556 for ; Mon, 10 Sep 2007 18:22:57 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l8AIMvIO2113656 for ; Mon, 10 Sep 2007 20:22:57 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l8AIMuKa011858 for ; Mon, 10 Sep 2007 20:22:57 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l8AIMuZG011855; Mon, 10 Sep 2007 20:22:56 +0200 Message-Id: <200709101822.l8AIMuZG011855@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 10 Sep 2007 20:22:56 +0200 Subject: Re: [patch 0/1] Threaded Watchpoints To: drow@false.org (Daniel Jacobowitz) Date: Mon, 10 Sep 2007 18:23:00 -0000 From: "Ulrich Weigand" Cc: luisgpm@linux.vnet.ibm.com (Luis Machado), gdb-patches@sourceware.org In-Reply-To: <20070910002103.GA25048@caradoc.them.org> from "Daniel Jacobowitz" at Sep 09, 2007 08:21:03 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00140.txt.bz2 Dan Jacobowitz wrote: > Most of this is liberally borrowed from Jeff's (and your's and Jan's) > work. There are some bits I'm not happy with yet, but I hope I'll > have time to finish it up this week or next weekend, and then I will > submit each logical change separately. Some of them deserve more > explanation (and comments and gdbint documentation). Thanks for working on this! I like the simplification of the infrun logic handling steppable/nonsteppable watchpoints. Was the change to remove use of HAVE_CONTINUABLE_WATCHPOINTS deliberate? It used to be that you had to set one of the three flags in order to activate the watchpoint logic at all, but your new code will always call STOPPED_BY_WATCHPOINT. Another question: +static void +s390_resume (ptid_t ptid, int step, enum target_signal signal) +{ + if (linux_nat_lwp_is_new (ptid)) + s390_fix_watch_points (ptid); + super_resume (ptid, step, signal); +} This assumes that the new thread's ptid will always be passed to the resume. Is this necessarily the case? I would expect ptid to be -1 in most cases ... > I've regression tested i386, amd64, and ia64. I tested S/390 by hand > and it works, but the extra logic in watchthreads.exp for that > platform hasn't been tested (no DejaGNU or expect on my test system). I did a full test on s390-ibm-linux and s390x-ibm-linux, and it works fine. There are no longer any FAILs reported for watchthreads.exp. I did have to define PTRACE_GETSIGINFO in linux-nat.c to get it to compile, however. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com