From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18027 invoked by alias); 8 Sep 2007 13:46:24 -0000 Received: (qmail 18019 invoked by uid 22791); 8 Sep 2007 13:46:23 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 08 Sep 2007 13:46:17 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 5B174982DF; Sat, 8 Sep 2007 13:46:17 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id F1534982C5; Sat, 8 Sep 2007 13:46:16 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IU0dZ-0007Hz-NZ; Sat, 08 Sep 2007 09:46:13 -0400 Date: Sat, 08 Sep 2007 13:46:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: [5/9] Associate parsed condition with location Message-ID: <20070908134613.GA27737@caradoc.them.org> Mail-Followup-To: Eli Zaretskii , Vladimir Prus , gdb-patches@sources.redhat.com References: <200709080042.24484.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00121.txt.bz2 On Sat, Sep 08, 2007 at 03:17:06PM +0300, Eli Zaretskii wrote: > We only need the function names, that's all. A year from now, someone > who will want to find out when this change was done in one of those > functions, will grep the ChangeLog's for the function's name. I don't think this is necessary, and it's definitely not customary. Here's two of the examples from the GNU Coding Standards. Re "Likewise": * register.el (insert-register): Return nil. (jump-to-register): Likewise. And for large mechanical changes: When you change the calling sequence of a function in a simple fashion, and you change all the callers of the function to use the new calling sequence, there is no need to make individual entries for all the callers that you changed. Just write in the entry for the function being called, ``All callers changed''---like this: @example * keyboard.c (Fcommand_execute): New arg SPECIAL. All callers changed. @end example -- Daniel Jacobowitz CodeSourcery