From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7430 invoked by alias); 7 Sep 2007 11:58:54 -0000 Received: (qmail 7421 invoked by uid 22791); 7 Sep 2007 11:58:53 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 07 Sep 2007 11:58:48 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id F3F7A982A4; Fri, 7 Sep 2007 11:58:48 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id D6D9D9814E; Fri, 7 Sep 2007 11:58:48 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1ITcU1-000553-Hz; Fri, 07 Sep 2007 07:58:45 -0400 Date: Fri, 07 Sep 2007 11:58:00 -0000 From: Daniel Jacobowitz To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [PING][Patch RFC] ARI changes for p-valprint.c Message-ID: <20070907115845.GA19110@caradoc.them.org> Mail-Followup-To: Pierre Muller , gdb-patches@sourceware.org References: <001601c7f137$937f3070$ba7d9150$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <001601c7f137$937f3070$ba7d9150$@u-strasbg.fr> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00081.txt.bz2 On Fri, Sep 07, 2007 at 12:12:20PM +0200, Pierre Muller wrote: > I could commit these as pascal maintainer, but I would like to have > feedback, > especially about how to phrase the ChangeLog entry, I put a minimal here, > but would like to know if more details are needed. Yes, more details are needed. It should have a function-level description of changes, except when you're making huge mechanical changes. > - deprecated_print_address_numeric (addr, 1, stream); > + fputs_filtered (paddress(addr), stream); Space before parentheses, please. > @@ -217,7 +217,7 @@ pascal_val_print (struct type *type, con > int is_this_fld; > > if (msymbol != NULL) > - wsym = lookup_symbol (DEPRECATED_SYMBOL_NAME (msymbol), > block, > + wsym = lookup_symbol ((msymbol)->ginfo.name, block, > VAR_DOMAIN, &is_this_fld, NULL); > > if (wsym) No, please don't use the members directly. Replace this with one of the other SYMBOL_*_NAME macros. Originally, this used to be SYMBOL_NAME; then the others were introduced, and this one was deprecated because it did not make clear what sort of name was wanted. Since it is being passed to lookup_symbol, SYMBOL_LINKAGE_NAME is probably best. > + fputs_filtered (paddress( Space again. Looks fine otherwise. Sorry for not getting to it before. -- Daniel Jacobowitz CodeSourcery