From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8815 invoked by alias); 6 Sep 2007 23:27:54 -0000 Received: (qmail 8802 invoked by uid 22791); 6 Sep 2007 23:27:53 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 06 Sep 2007 23:27:48 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id DD1BD982A2 for ; Thu, 6 Sep 2007 23:27:48 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id BC05998152 for ; Thu, 6 Sep 2007 23:27:48 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1ITQlF-0004ci-I2 for gdb-patches@sourceware.org; Thu, 06 Sep 2007 19:27:45 -0400 Date: Thu, 06 Sep 2007 23:27:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: [commit] Fix gdb.mi watchpoint tests for remote Message-ID: <20070906232745.GA17695@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00079.txt.bz2 The non-MI watchpoint tests do the same thing: if the board file requests we not try hardware watchpoints, tell GDB not to. So I made the MI watchpoint tests do the same, which fixes two failures when using gdbserver. Of course this makes the tests run with software watchpoints. They happen to fail, because we don't realize when we're in the epilogue early enough (true on both amd64 and powerpc). Progress, anyway... Tested x86_64-linux and committed. -- Daniel Jacobowitz CodeSourcery 2007-09-06 Daniel Jacobowitz * gdb.mi/mi2-watch.exp: Set can-use-hw-watchpoints to 0 if required. * gdb.mi/mi-watch.exp: Likewise. Index: gdb/testsuite/gdb.mi/mi2-watch.exp =================================================================== --- gdb/testsuite/gdb.mi/mi2-watch.exp (revision 181154) +++ gdb/testsuite/gdb.mi/mi2-watch.exp (revision 181155) @@ -168,6 +168,11 @@ proc test_watchpoint_triggering {} { } } +# Disable hardware watchpoints if necessary. +if [target_info exists gdb,no_hardware_watchpoints] { + mi_gdb_test "-gdb-set can-use-hw-watchpoints 0" "\\^done" "" +} + mi_runto callee4 test_watchpoint_creation_and_listing #test_rwatch_creation_and_listing Index: gdb/testsuite/gdb.mi/mi-watch.exp =================================================================== --- gdb/testsuite/gdb.mi/mi-watch.exp (revision 181154) +++ gdb/testsuite/gdb.mi/mi-watch.exp (revision 181155) @@ -168,6 +168,11 @@ proc test_watchpoint_triggering {} { } } +# Disable hardware watchpoints if necessary. +if [target_info exists gdb,no_hardware_watchpoints] { + mi_gdb_test "-gdb-set can-use-hw-watchpoints 0" "\\^done" "" +} + mi_runto callee4 test_watchpoint_creation_and_listing #test_rwatch_creation_and_listing