From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1476 invoked by alias); 3 Sep 2007 20:16:22 -0000 Received: (qmail 1466 invoked by uid 22791); 3 Sep 2007 20:16:22 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 03 Sep 2007 20:16:12 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 60E6B982A2 for ; Mon, 3 Sep 2007 20:16:12 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 416E498109 for ; Mon, 3 Sep 2007 20:16:12 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1ISILB-00072D-3m for gdb-patches@sourceware.org; Mon, 03 Sep 2007 16:16:09 -0400 Date: Mon, 03 Sep 2007 20:16:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [patch, rfc, rft] Multi-threaded single-step vs. breakpoint problems (prepare_to_proceed) Message-ID: <20070903201609.GA26767@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20070802194220.GB6563@caradoc.them.org> <200708031654.l73GsY1Q018103@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200708031654.l73GsY1Q018103@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00036.txt.bz2 On Fri, Aug 03, 2007 at 06:54:34PM +0200, Ulrich Weigand wrote: > ChangeLog: > > * infrun.c (stepping_past_breakpoint): New global variable. > (stepping_past_breakpoint_ptid): Likewise. > (prepare_to_proceed): Add STEP parameter. Do not check for Ctrl-C. > Only switch threads if we need to single-step over a breakpoint hit > in the previously selected thread. If stepping, remember previous > thread to switch back to in STEPPING_PAST_BREAKPOINT[_PTID]. Call > switch_to_thread instead of copying its contents. > (proceed): Pass STEP to prepare_to_proceed. Always set ONEPROC if > prepare_to_proceed returns true. > (init_wait_for_inferior): Reset STEPPING_PAST_BREAKPOINT. > (context_switch): Call switch_to_thread. > (handle_inferior_event): Switch back to previous thread if requested > in STEPPING_PAST_BREAKPOINT[_PTID] by prepare_to_proceed. > * gdbthread.h (switch_to_thread): Add prototype. > * thread.c (switch_to_thread): Make global. No one else has commented on this patch in the last month; I think you should probably commit it (though you may wish to wait until after the release branch - I've no preference). -- Daniel Jacobowitz CodeSourcery