From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25801 invoked by alias); 3 Sep 2007 17:45:41 -0000 Received: (qmail 25791 invoked by uid 22791); 3 Sep 2007 17:45:40 -0000 X-Spam-Check-By: sourceware.org Received: from phoenix.bawue.net (HELO mail.bawue.net) (193.7.176.60) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 03 Sep 2007 17:45:34 +0000 Received: from lagash (intrt.mips-uk.com [194.74.144.130]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.bawue.net (Postfix) with ESMTP id 51FF6BAE65; Mon, 3 Sep 2007 19:35:24 +0200 (CEST) Received: from ths by lagash with local (Exim 4.67) (envelope-from ) id 1ISFpb-00006s-7B; Mon, 03 Sep 2007 18:35:23 +0100 Date: Mon, 03 Sep 2007 17:45:00 -0000 From: Thiemo Seufer To: Nick Clifton , gdb-patches@sourceware.org Subject: Re: RFA: Make --memory-info work for MIPS simulators Message-ID: <20070903173523.GD29574@networkno.de> References: <20070903171438.GB12440@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20070903171438.GB12440@caradoc.them.org> User-Agent: Mutt/1.5.16 (2007-06-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00032.txt.bz2 Daniel Jacobowitz wrote: > On Fri, Aug 10, 2007 at 11:38:10AM +0100, Nick Clifton wrote: > > sim/mips/ChangeLog > > 2007-08-10 Nick Clifton > >=20 > > * interp.c (options enum): Add OPTION_INFO_MEMORY. > > (display_mem_info): New static variable. > > (mips_option_handler): Handle OPTION_INFO_MEMORY. > > (mips_options): Add info-memory and memory-info. > > (sim_open): After processing the command line and board > > specification, check display_mem_info. If it is set then > > call the real handler for the --memory-info command line > > switch. >=20 > I didn't see any response to this patch. I think it's OK to commit, > though. I sent the appended email on 2007-08-13, it seems it didn't reach the list for some reason. Thiemo =46rom ths@networkno.de Mon Aug 13 18:15:43 2007 Date: Mon, 13 Aug 2007 18:15:43 +0100 From: Thiemo Seufer To: Nick Clifton Cc: gdb-patches@sourceware.org Subject: Re: RFA: Make --memory-info work for MIPS simulators Message-ID: <20070813171543.GB19507@networkno.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=3Dus-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-11) Status: RO Content-Length: 2065 Lines: 58 Nick Clifton wrote: > Hi Thiemo, >=20 > The --memory-info command line switch (and its alias --info-memory) > do not work for the MIPS simulator because the memory regions are > not set up until after the command line has been parsed. The > attached patch fixes this by delaying the processing of > --memory-info until after the regions have been initialized. >=20 > The patch does have one slightly dubious component - it removes the > mips specific command line options table from the linked list of > options tables once the command line has been processed. It does > this so that the real handler for --memory-info can be called via > the sim_do_commandf() function. I think that this is safe, since > there is no longer any need to process mips specific command line > switches. >=20 > Before the patch: >=20=20=20 > % mips64vrel-elf-run --memory-info a.out > Memory maps: >=20=20=20=20=20 > After the patch: >=20 > % mips64vrel-elf-run --memory-info a.out > Memory maps: > memory region 0x7fff8000,0x8000 > memory alias 0xa0000000@0x1,0x20000000%0x800000,0x80000000@0x1 >=20 > May I apply this patch please ? >=20 > Cheers > Nick >=20 > PS. The sim/MAINTAINERS file has your email address as > , judging from the ChangeLog though, I guessed that > this was incorrect. In the Changelog I use the mips.com mail address for changes which are covered by the MTI copyright assignment, the networkno.de address is for contributions which fall under my personal copyright assignment. > sim/mips/ChangeLog > 2007-08-10 Nick Clifton >=20 > * interp.c (options enum): Add OPTION_INFO_MEMORY. > (display_mem_info): New static variable. > (mips_option_handler): Handle OPTION_INFO_MEMORY. > (mips_options): Add info-memory and memory-info. > (sim_open): After processing the command line and board > specification, check display_mem_info. If it is set then > call the real handler for the --memory-info command line > switch. Ok. Thiemo