From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12796 invoked by alias); 3 Sep 2007 09:29:00 -0000 Received: (qmail 12785 invoked by uid 22791); 3 Sep 2007 09:28:59 -0000 X-Spam-Check-By: sourceware.org Received: from pauline.vellum.cz (HELO pauline.vellum.cz) (89.250.243.234) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 03 Sep 2007 09:28:50 +0000 Received: from host0.dyn.jankratochvil.net (localhost.localdomain [127.0.0.1]) by pauline.vellum.cz (8.12.11.20060308/8.12.11) with ESMTP id l839SkUa011693 for ; Mon, 3 Sep 2007 11:28:47 +0200 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.1/8.13.8) with ESMTP id l839SkFS021047 for ; Mon, 3 Sep 2007 11:28:46 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.1/8.14.1/Submit) id l839Skmx021046 for gdb-patches@sourceware.org; Mon, 3 Sep 2007 11:28:46 +0200 Date: Mon, 03 Sep 2007 09:29:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [testsuite patch approval?] Re: Back-Cover Text and --version updates Message-ID: <20070903092846.GA21028@host0.dyn.jankratochvil.net> References: <20070902140855.GA6993@caradoc.them.org> <20070902200216.GA21817@caradoc.them.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="KsGdsel6WgEHnImy" Content-Disposition: inline In-Reply-To: <20070902200216.GA21817@caradoc.them.org> User-Agent: Mutt/1.5.14 (2007-02-12) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00020.txt.bz2 --KsGdsel6WgEHnImy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 240 On Sun, 02 Sep 2007 22:02:16 +0200, Daniel Jacobowitz wrote: ... > Thanks for the review. I've checked it in now. Testsuite also needs an update. Patch approval requested; some more inexact patterns may be the better way. Regards, Jan --KsGdsel6WgEHnImy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="gdb-version-testsuite-update.patch" Content-length: 3716 2007-09-03 Jan Kratochvil * gdb.base/default.exp (show version): Update the version text. * gdb.gdb/selftest.exp (xgdb is at prompt): Likewise. --- gdb/testsuite/gdb.base/default.exp 23 Aug 2007 20:36:15 -0000 1.24 +++ gdb/testsuite/gdb.base/default.exp 3 Sep 2007 09:23:20 -0000 @@ -665,7 +665,7 @@ gdb_test "show values" "" "show values" #test show verbose gdb_test "show verbose" "Verbose printing of informational messages is o.*|Verbosity is off.*" "show verbose" #test show version -gdb_test "show version" "GNU gdb \[0-9\.\]*(\[^\r\n\]*\[\r\n\])+Copyright \\(C\\) \[0-9\]* Free Software Foundation, Inc(\[^\r\n\]*\[\r\n\])+GDB is free software, covered by the GNU General Public License, and you are(\[^\r\n\]*\[\r\n\])+welcome to change it and/or distribute copies of it under certain conditions(\[^\r\n\]*\[\r\n\])+Type \"show copying\" to see the conditions(\[^\r\n\]*\[\r\n\])+There is absolutely no warranty for GDB. Type \"show warranty\" for details(\[^\r\n\]*\[\r\n\])+This GDB was configured as .*|GDB is free software and you are welcome to distribute copies of it(\[^\r\n\]*\[\r\n\])+ under certain conditions; type \"show copying\" to see the conditions.(\[^\r\n\]*\[\r\n\])+There is absolutely no warranty for GDB; type \"show warranty\" for details.(\[^\r\n\]*\[\r\n\])+GDB.*Copyright \\(C\\) \[0-9\]* Free Software Foundation, Inc.*" "show version" +gdb_test "show version" "GNU gdb \[0-9\.\]*(\[^\r\n\]*\[\r\n\])+Copyright \\(C\\) \[0-9\]* Free Software Foundation, Inc(\[^\r\n\]*\[\r\n\])+License GPLv3\\+: GNU GPL version 3 or later (\[^\r\n\]*\[\r\n\])+This is free software: you are free to change and redistribute it.(\[^\r\n\]*\[\r\n\])+There is NO WARRANTY, to the extent permitted by law. Type \"show copying\"(\[^\r\n\]*\[\r\n\])+and \"show warranty\" for details..*" "show version" #test show width gdb_test "show width" "Number of characters gdb thinks are in a line is.*" "show width" #test show write --- gdb/testsuite/gdb.gdb/selftest.exp 23 Aug 2007 18:14:18 -0000 1.13 +++ gdb/testsuite/gdb.gdb/selftest.exp 3 Sep 2007 09:23:20 -0000 @@ -411,17 +411,25 @@ proc test_with_self { executable } { gdb_expect { -re "GNU gdb \[0-9\.\]*.* Copyright \\(C\\) \[0-9\]* Free Software Foundation, Inc.* +License GPLv3\\+: GNU GPL version 3 or later .* +This is free software: you are free to change and redistribute it.* +There is NO WARRANTY, to the extent permitted by law. Type \"show copying\".* +and \"show warranty\" for details.* +This GDB was configured as .*$gdb_prompt $"\ + { pass "xgdb is at prompt" } + -re "GNU gdb \[0-9\.\]*.* +Copyright \\(C\\) \[0-9\]* Free Software Foundation, Inc.* GDB is free software, covered by the GNU General Public License, and you are.* welcome to change it and/or distribute copies of it under certain conditions.* Type \"show copying\" to see the conditions.* There is absolutely no warranty for GDB. Type \"show warranty\" for details.* This GDB was configured as .*$gdb_prompt $"\ - { pass "xgdb is at prompt" } + { pass "xgdb is at prompt (obsolescent gdb 2)" } -re "GDB is free software and you are welcome to distribute copies of it.* under certain conditions; type \"show copying\" to see the conditions..* There is absolutely no warranty for GDB; type \"show warranty\" for details..* GDB.*Copyright \[0-9\]+ Free Software Foundation, Inc..*$gdb_prompt $"\ - { pass "xgdb is at prompt (obsolescent gdb)" } + { pass "xgdb is at prompt (obsolescent gdb 1)" } -re ".*$gdb_prompt $" { fail "xgdb is at prompt" } timeout { fail "(timeout) xgdb is at prompt" } } --KsGdsel6WgEHnImy--