From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7360 invoked by alias); 29 Aug 2007 18:37:48 -0000 Received: (qmail 7352 invoked by uid 22791); 29 Aug 2007 18:37:47 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 29 Aug 2007 18:37:42 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.1/8.14.0) with ESMTP id l7TIZ3Xu011638; Wed, 29 Aug 2007 20:35:03 +0200 (CEST) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id l7TIZ2Th015104; Wed, 29 Aug 2007 20:35:02 +0200 (CEST) Date: Wed, 29 Aug 2007 18:37:00 -0000 Message-Id: <200708291835.l7TIZ2Th015104@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: jimb@codesourcery.com CC: gdb-patches@sourceware.org In-reply-to: (message from Jim Blandy on Wed, 29 Aug 2007 11:06:04 -0700) Subject: Re: RFA: Delete broken and unused HPUXHPPA code References: Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00520.txt.bz2 > From: Jim Blandy > Date: Wed, 29 Aug 2007 11:06:04 -0700 > > The #ifdef block this patch deletes contains unbalanced parenthesis; > it wouldn't compile. The mistake was introduced by this change: > > 2005-02-10 Andrew Cagney > > Mark up all error and warning messages. > > Since nobody has noticed it, it's clear that nobody has compiled this > code with HPUXHPPA defined for two and a half years. The block of > code itself dates from GDB's prehistory. This is the only "HPUXHPPA" > block in all of GDB. > > Can we delete the code? > > gdb/ChangeLog: > 2007-08-29 Jim Blandy > > * breakpoint.c (watch_command_1): Remove '#ifdef HPUXHPPA' block; > this code has not been compiled for two years. Go for it.