From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3740 invoked by alias); 24 Aug 2007 03:50:45 -0000 Received: (qmail 3606 invoked by uid 22791); 24 Aug 2007 03:50:43 -0000 X-Spam-Check-By: sourceware.org Received: from pool-96-233-71-216.bstnma.fios.verizon.net (HELO ednor.cgf.cx) (96.233.71.216) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 24 Aug 2007 03:50:39 +0000 Received: by ednor.cgf.cx (Postfix, from userid 201) id 537302B352; Thu, 23 Aug 2007 23:50:37 -0400 (EDT) Date: Fri, 24 Aug 2007 03:50:00 -0000 From: Christopher Faylor To: Ian Lance Taylor , gdb-patches@sourceware.org, binutils@sourceware.org, gcc-patches@gcc.gnu.org, Kai Tietz Subject: Re: [PING x 2 patch]: libiberty pex for _WIN64 Message-ID: <20070824035037.GA13193@ednor.casa.cgf.cx> Mail-Followup-To: Ian Lance Taylor , gdb-patches@sourceware.org, binutils@sourceware.org, gcc-patches@gcc.gnu.org, Kai Tietz References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00457.txt.bz2 On Thu, Aug 23, 2007 at 10:22:55AM +0200, Kai Tietz wrote: >Hi Ian, > >> Kai Tietz writes: >> >> > 2007-08-03 Kai Tietz >> > >> > * pex-common.h: (pex_funcs): Retyped wait and exec_child to >pid_t. >> > * pex-djgpp.c: Likewise. >> > * pex-msdos.c: Likewise. >> > * pex-unix.c: Likewise. >> > * pex-win32.c: Likewise. >> >> This is OK if it passes bootstrap on a Unix or GNU/Linux system. > >It passes bootstrap on cygwin, x86_64 mingw, and i386 linux. >There was a bug that if configure detects the 'sys/types.h' defines the >pid_t, it was not included to define it. I added the include for it by >using the config.h define HAVE_SYS_TYPES_H. > >Is this patch OK to be applied ? > >Cheers, > i.A. Kai Tietz > >PS: I can just check it in on binutils and gcc repository. On the other >repositories I can't. AFAIK, those are only two repositories that this would be applicable to. gdb, newlib, and cygwin all share a repository with binutils. cgf