From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5164 invoked by alias); 23 Aug 2007 19:55:39 -0000 Received: (qmail 5077 invoked by uid 22791); 23 Aug 2007 19:55:38 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 23 Aug 2007 19:55:33 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E6DEE2A9A8F for ; Thu, 23 Aug 2007 15:52:17 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id SME4iEDCyj1c for ; Thu, 23 Aug 2007 15:52:17 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CE0B52A9A8B for ; Thu, 23 Aug 2007 15:52:17 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 435BFE7B58; Thu, 23 Aug 2007 15:56:24 -0400 (EDT) Date: Thu, 23 Aug 2007 19:55:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [RFA/testsuite] Increase expect buffer size (related to GPLv3) Message-ID: <20070823195624.GC6056@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="NzB8fVQJ5HfG6fxh" Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00450.txt.bz2 --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 898 Hello, After switching "info copying/warranty" to GPLv3, the testsuite showed one regression (expected), and two ERRORs because of expect buffer overflow. The overflow comes from the fact that the GPLv3 terms are much longer than the terms in GPLv2. I think the attached patch is the appropriate change, but perhaps there is a way to change the buffer size locally for the test or the testcase, instead of expanding it globally for all testcases. I really don't think that growing the buffer to 30kb (from 20kb) is a big deal, but perhaps it has some effects that I haven't noticed (like performance hits)... Hence the RFA rather than committing it using the obvious rule. 2007-08-23 Joel Brobecker * lib/gdb.exp (default_gdb_init): Increase expect buffer size to 30000 (from 20000). Tested on x86-linux. No regression. OK to apply? Thanks, -- Joel --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="lib-gdb.diff" Content-length: 945 Index: lib/gdb.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v retrieving revision 1.85 diff -u -p -r1.85 gdb.exp --- lib/gdb.exp 23 Aug 2007 18:14:19 -0000 1.85 +++ lib/gdb.exp 23 Aug 2007 19:51:59 -0000 @@ -2085,9 +2085,10 @@ proc default_gdb_init { args } { # with the appropriate multilib option. set gdb_wrapper_initialized 0 - # Uh, this is lame. Really, really, really lame. But there's this *one* - # testcase that will fail in random places if we don't increase this. - match_max -d 20000 + # Unlike most tests, we have a small number of tests that generate + # a very large amount of output. We therefore increase the expect + # buffer size to be able to contain the entire test output. + match_max -d 30000 # We want to add the name of the TCL testcase to the PASS/FAIL messages. if { [llength $args] > 0 } { --NzB8fVQJ5HfG6fxh--