From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11729 invoked by alias); 16 Aug 2007 01:59:12 -0000 Received: (qmail 11202 invoked by uid 22791); 16 Aug 2007 01:59:10 -0000 X-Spam-Check-By: sourceware.org Received: from pool-72-70-61-242.bstnma.fios.verizon.net (HELO ednor.cgf.cx) (72.70.61.242) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 16 Aug 2007 01:59:08 +0000 Received: by ednor.cgf.cx (Postfix, from userid 201) id 2466A2B353; Wed, 15 Aug 2007 21:59:07 -0400 (EDT) Date: Thu, 16 Aug 2007 01:59:00 -0000 From: Christopher Faylor To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: Windows DLL support update. Message-ID: <20070816015907.GA4167@ednor.casa.cgf.cx> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <46C0F600.5010607@portugalmail.pt> <20070814121008.GA18838@ednor.casa.cgf.cx> <46C39D10.3020001@portugalmail.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46C39D10.3020001@portugalmail.pt> User-Agent: Mutt/1.5.15 (2007-04-06) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00326.txt.bz2 On Thu, Aug 16, 2007 at 01:40:48AM +0100, Pedro Alves wrote: > Christopher Faylor wrote: >> On Tue, Aug 14, 2007 at 01:23:28AM +0100, Pedro Alves wrote: >>> Here is the new version of the patch that converts native win32 >>> debugging to use the new solib-target.c. >> I have a few of questions/observations wrt the win32-nat.c changes. > > Thanks for such a quick review. > >> 1) Does it still properly handle the "exceptions" that are thrown by >> cygwin which must be ignored? I believe that the most populr source >> of complaints about those came from people who were using pthreads >> functions. > > Yes. I tried with this: > http://www.cygwin.com/ml/cygwin/2006-05/msg00650.html > > 'set cygwin-exceptions 1' shows the SEGV, 'set cygwin-exceptions 0' > doesn't. > >> 2) Is there some reason you didn't record the cygwin load/start address >> in win32_make_so? Isn't all of the information you need available when >> that function is called? > > I could open a bfd and look for .text like old solib_symbols_add > does, but the so_list of the main list will have one open, so we can > use that instead. I'll want to move these bits of cygwin detection and > exception ignoring into a win32-tdep.c file that can be reused > when remote debugging. This is step in that direction, but I'll > understand if you still prefer the old way. > >> 3) If the answer to the above question is no, then it seems like >> cygwin_load_start and cygwin_load_end should be static variables local >> to ignore_access_violation_p. > > Storing the cygwin1.dll addresses and reusing > it across runs should be ok if we assume that we are always > debugging cygwin apps, but it could mask an access exception in > a non-cygwin app that happened to occur in a dll loaded in that > range by coincidence. I was going to leave it for later, but > since you've asked, I'm now clearing the start/end addresses > in do_initial_win32_stuff. This shows why they can't be local > static. > > > I wonder if that logic should even be > > further broken out into its own inside_cygwin(addr) function. > > Wonder no more. Done. > >> 4) I'd prefer it if you dropped the _p from "ignore_access_violation". > > Done. > > > I gave it another testsuite spin, and it looks good. Ok. I approve the win32 specific parts. Thanks for the explanations. cgf