From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10011 invoked by alias); 16 Aug 2007 00:57:36 -0000 Received: (qmail 9978 invoked by uid 22791); 16 Aug 2007 00:57:35 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 16 Aug 2007 00:57:33 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id B4A3E98308; Thu, 16 Aug 2007 00:57:33 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 864519812E; Thu, 16 Aug 2007 00:57:33 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1ILTg3-0004Eu-3P; Wed, 15 Aug 2007 20:57:31 -0400 Date: Thu, 16 Aug 2007 00:57:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: Windows DLL support update. Message-ID: <20070816005731.GA16007@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <46C0F600.5010607@portugalmail.pt> <20070814121008.GA18838@ednor.casa.cgf.cx> <46C39D10.3020001@portugalmail.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46C39D10.3020001@portugalmail.pt> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00325.txt.bz2 On Thu, Aug 16, 2007 at 01:40:48AM +0100, Pedro Alves wrote: > I gave it another testsuite spin, and it looks good. I have one concern; one of us should fix the problem Ulrich pointed out with my core changes: > On Tue, Jun 19, 2007 at 09:05:51PM +0200, Ulrich Weigand wrote: > > One thing I don't quite like is this: > > > > > + case TARGET_OBJECT_LIBRARIES: > > > + if (core_vec->xfer_shared_libraries != NULL) > > > + return core_vec->xfer_shared_libraries (ops, object, annex, > > > readbuf, > > > + writebuf, offset, len); > > > > I had understood the core_fns method of providing a core file target > > to > > be deprecated, and in fact I just recently got rid of it for AIX in > > favour > > of the gdbarch_regset_from_core_section callback ... I'd prefer > > this to > > be a gdbarch callback (which would also support core file > > cross-debugging). > > I hadn't even thought about it. Yes, you're right. Also, we added #include's so the Makefile needs an update. > +/* Returns 1 if ADDR is within the cygwin1.dll text segment, returns 0 > + otherwise. */ > +static int > +inside_cygwin (CORE_ADDR addr) > +{ > + if (cygwin_load_start == 0) > + { > + struct so_list *so; > + > + for (so = master_so_list (); so; so = so->next) Nothing outside of the solib implementations calls master_so_list. I think that's best; can you use ALL_OBJFILES here instead? > + if (data->module_count == 0) > + { > +#if 0 > + /* TODO: What if the user supplied exec and/or > + symbol files on the command line? */ > + /* The first module is the .exe itself. */ > + symbol_file_add_main (module_name, 0); > +#endif > + } > + else > + { > + struct so_list *so = win32_make_so (module_name, base_addr); > + solib_to_xml (so, data->obstack); > + win32_free_so (so); > + } > + data->module_count++; Let's not add #if 0 / TODO. I think we can drop this code, how about you? Other than that it looks good to me if it looks good to Chris. -- Daniel Jacobowitz CodeSourcery