From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20890 invoked by alias); 8 Aug 2007 14:12:06 -0000 Received: (qmail 20824 invoked by uid 22791); 8 Aug 2007 14:12:05 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 08 Aug 2007 14:11:58 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id l78EBt9Q927174 for ; Wed, 8 Aug 2007 14:11:55 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.4) with ESMTP id l78EBtPE2322604 for ; Wed, 8 Aug 2007 16:11:55 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l78EBqaY022785 for ; Wed, 8 Aug 2007 16:11:52 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l78EBqII022771; Wed, 8 Aug 2007 16:11:52 +0200 Message-Id: <200708081411.l78EBqII022771@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 8 Aug 2007 16:11:52 +0200 Subject: Re: [rfc] Wrap addresses in spu-gdb To: drow@false.org (Daniel Jacobowitz), deuling@de.ibm.com (Markus Deuling) Date: Wed, 08 Aug 2007 14:12:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <20070808114237.GA27165@caradoc.them.org> from "Daniel Jacobowitz" at Aug 08, 2007 07:42:37 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00143.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Aug 08, 2007 at 08:44:29AM +0200, Markus Deuling wrote: > > + if (target_has_registers && target_has_stack && target_has_memory > > + /* FIXME: Currently needed for dwarf2_read_address to work. */ > > + && type != builtin_type_uint32) > > I think that you shouldn't commit a patch with this hack in it. > It looks very fragile. Agreed. Markus, this is a special hack for the combined PPE/SPE debugger, it shouldn't be necessary for the SPU-standalone (and mainline) version. I'll have to look into fixing the underlying issue cleanly when merging the combined debugger ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com