Re: [RFA] fix build failure in solib-som.c

Kevin Buettner
2007-08-07T21:47:43Z

On Tue, 7 Aug 2007 13:45:29 -0700
Joel Brobecker <brobecker@adacore.com> wrote:

> It looks like a change made a month ago that removed a field called
> textsection from the so_list structure is the cause for a build failure
> in solib-som.c.
>
> I haven't tested this change, but wouldn't the attached patch make sense?
> I don't think we need to keep track of which section is the text section
> at this place, since this is done differently somewhere else (in the
> current_sos method). So I just removed the associated piece of code.
>
> 2007-08-07 Joel Brobecker <brobecker@adacore.com>
>
> * solib-som.c (som_relocate_section_addresses): Stop saving
> the $CODE$ section in the so_list structure.
>
> This files compiles fine again after this change is applied.
>
> Would that be OK to apply?

I think it would be better to revise the code to set so->addr_low and
so->addr_high to sec->addr and sec->endaddr respectively. You'll also
have to move this block of code to the end of the function.

Kevin