From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25307 invoked by alias); 3 Aug 2007 14:51:49 -0000 Received: (qmail 25297 invoked by uid 22791); 3 Aug 2007 14:51:49 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 03 Aug 2007 14:51:45 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 95CEB98123; Fri, 3 Aug 2007 14:51:44 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 73DBE98122; Fri, 3 Aug 2007 14:51:44 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IGyVC-0006kh-2i; Fri, 03 Aug 2007 10:51:42 -0400 Date: Fri, 03 Aug 2007 14:51:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH] symfile.c, find_separate_debug_file Message-ID: <20070803145142.GA25941@caradoc.them.org> Mail-Followup-To: Michael Snyder , Eli Zaretskii , gdb-patches@sourceware.org References: <10431.12.7.175.2.1186103684.squirrel@webmail.sonic.net> <20070803013005.GA22901@caradoc.them.org> <006901c7d587$db360400$677ba8c0@sonic.net> <001301c7d5db$d5702880$677ba8c0@sonic.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <001301c7d5db$d5702880$677ba8c0@sonic.net> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00053.txt.bz2 On Fri, Aug 03, 2007 at 07:37:35AM -0700, Michael Snyder wrote: > Yes, I understood exactly what Daniel meant. I was saying, > the existing code uses the literal '/' instead of the symbolic > DIR_SEPARATOR. > > I offered to have another go at the code and clean up the literals, > but as a separate patch to this one. You added two lines: ! if (debugfile[strlen (debugfile) - 1] != '/' && dir[0] != '/') ! strcat (debugfile, "/"); I think you're talking about the second one, which adds a "/". That's fine, but the first line isn't. Other places in that function which compare against '/' use IS_DIR_SEPARATOR already. -- Daniel Jacobowitz CodeSourcery