From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22963 invoked by alias); 3 Aug 2007 01:30:15 -0000 Received: (qmail 22954 invoked by uid 22791); 3 Aug 2007 01:30:14 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 03 Aug 2007 01:30:08 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 17CCA98122; Fri, 3 Aug 2007 01:30:08 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 01B3498100; Fri, 3 Aug 2007 01:30:07 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IGlzR-0005xf-JH; Thu, 02 Aug 2007 21:30:05 -0400 Date: Fri, 03 Aug 2007 01:30:00 -0000 From: Daniel Jacobowitz To: msnyder@sonic.net Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] symfile.c, find_separate_debug_file Message-ID: <20070803013005.GA22901@caradoc.them.org> Mail-Followup-To: msnyder@sonic.net, gdb-patches@sourceware.org References: <10431.12.7.175.2.1186103684.squirrel@webmail.sonic.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10431.12.7.175.2.1186103684.squirrel@webmail.sonic.net> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00029.txt.bz2 On Thu, Aug 02, 2007 at 06:14:44PM -0700, Michael Snyder wrote: > Just for a change, here's one that was not inspired by Coverity. > > Find separate debug file does not work in the case where the path > lies in the global debug file directory -- because we stick an extra > slash into the pathname. Why doesn't it work with an extra slash? It shouldn't make a difference. Anyway: > * symfile.c (find_separate_debug_file): While consing up a path, > don't stick in an extra DIR_SEPARATOR. That's right, use DIR_SEPARATOR :-) IS_DIR_SEPARATOR in this case, I think? -- Daniel Jacobowitz CodeSourcery