From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4379 invoked by alias); 2 Aug 2007 21:37:33 -0000 Received: (qmail 4370 invoked by uid 22791); 2 Aug 2007 21:37:32 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 02 Aug 2007 21:37:27 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id F164B98122; Thu, 2 Aug 2007 21:37:26 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id D705298100; Thu, 2 Aug 2007 21:37:26 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IGiMG-0003FT-Oq; Thu, 02 Aug 2007 17:37:24 -0400 Date: Thu, 02 Aug 2007 21:37:00 -0000 From: Daniel Jacobowitz To: msnyder@sonic.net Cc: gdb-patches@sourceware.org Subject: Re: FW: [PATCH] jv-lang, guard against NULL Message-ID: <20070802213724.GA12451@caradoc.them.org> Mail-Followup-To: msnyder@sonic.net, gdb-patches@sourceware.org References: <12757.12.7.175.2.1185924312.squirrel@webmail.sonic.net> <20070802210606.GF6563@caradoc.them.org> <655C3D4066B7954481633935A40BB36F22BA4C@ussunex02.svl.access-company.com> <12786.12.7.175.2.1186090201.squirrel@webmail.sonic.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12786.12.7.175.2.1186090201.squirrel@webmail.sonic.net> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00027.txt.bz2 On Thu, Aug 02, 2007 at 02:30:01PM -0700, Michael Snyder wrote: > Good idea -- except, can we really be sure that name can > never legitimately be null? Oh, yeah, I guess the unprotected > strrchr sort of tells us that, doesn't it? > > OK, how about this? I've no complaint. I don't think this sort of assert adds much value, though. -- Daniel Jacobowitz CodeSourcery