From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] jv-lang, guard against NULL
Date: Thu, 02 Aug 2007 21:06:00 -0000 [thread overview]
Message-ID: <20070802210606.GF6563@caradoc.them.org> (raw)
In-Reply-To: <12757.12.7.175.2.1185924312.squirrel@webmail.sonic.net>
On Tue, Jul 31, 2007 at 04:25:12PM -0700, Michael Snyder wrote:
> ! if (name != NULL && (i = strlen (name)) > 2
> ! && name[i - 1] == ']' && tsuper != NULL)
Can we avoid assignments inside the if statement? Also, there's an
unprotected call to strrchr above. Maybe this should be an assert
instead, at the top of the function.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-08-02 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 23:29 msnyder
2007-08-02 21:06 ` Daniel Jacobowitz [this message]
[not found] ` <655C3D4066B7954481633935A40BB36F22BA4C@ussunex02.svl.access-company.com>
[not found] ` <655C3D4066B7954481633935A40BB36F22BA4C@ussunex02.svl.access-company.c om>
2007-08-02 21:30 ` FW: " msnyder
2007-08-02 21:37 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070802210606.GF6563@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox