From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12098 invoked by alias); 1 Aug 2007 22:00:12 -0000 Received: (qmail 12071 invoked by uid 22791); 1 Aug 2007 22:00:09 -0000 X-Spam-Check-By: sourceware.org Received: from sccrmhc14.comcast.net (HELO sccrmhc14.comcast.net) (63.240.77.84) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 01 Aug 2007 22:00:03 +0000 Received: from lucon.org ([24.6.230.138]) by comcast.net (sccrmhc14) with ESMTP id <200708012200010140018v75e>; Wed, 1 Aug 2007 22:00:01 +0000 Received: by lucon.org (Postfix, from userid 500) id E7DCDF7F56; Wed, 1 Aug 2007 15:00:00 -0700 (PDT) Date: Wed, 01 Aug 2007 22:00:00 -0000 From: "H.J. Lu" To: msnyder@sonic.net Cc: gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: [PATCH] opcodes/i386-dis.c, print_insn, null ptr. Message-ID: <20070801220000.GA4705@lucon.org> References: <6845.12.7.175.2.1186002936.squirrel@webmail.sonic.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6845.12.7.175.2.1186002936.squirrel@webmail.sonic.net> User-Agent: Mutt/1.5.14 (2007-02-12) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00016.txt.bz2 On Wed, Aug 01, 2007 at 02:15:36PM -0700, msnyder@sonic.net wrote: > If we come to this point via the default case in the switch > statement above, we will not have updated 'dp' and dp->name > will still be null. Then putop will dereference it. > > 2007-08-01 Michael Snyder > > * i386-dis.c (print_insn): Guard against NULL. > It is OK. Thanks. H.J.