From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
gdb-patches@sourceware.org, Alex <alex00882007@gmail.com>
Subject: Re: [rfc] Do not read from the executable if ptrace fails
Date: Mon, 23 Jul 2007 21:25:00 -0000 [thread overview]
Message-ID: <20070723191542.GA12138@caradoc.them.org> (raw)
In-Reply-To: <200707231902.l6NJ2dJC004817@d12av02.megacenter.de.ibm.com>
On Mon, Jul 23, 2007 at 09:02:33PM +0200, Ulrich Weigand wrote:
> I only noticed now, but this breaks SPU overlay support.
:-(
> Overlay support uses "LMA" addresses to refer to overlay sections
> not currently loaded, and performs xfer_partial requests to read
> from those (e.g. when invoking skip_prologue on a function not
> currently present).
>
> This works only if accesses to those LMA addresses go through to
> the xfer_memory routine in exec.c, which implements the required
> logic to retrieve those section contents from the executable file.
>
> This used to work (probably accidentally?), but is broken by
> this patch. Any suggestions how to fix it? Should the overlay
> logic from xfer_memory be moved to memory_xfer_partial, maybe?
That sounds reasonable. What about if we check for an unmapped
overlay address at the same point we handle trust_readonly?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-07-23 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 3:09 Daniel Jacobowitz
2007-06-26 0:53 ` Joel Brobecker
2007-07-01 22:36 ` Daniel Jacobowitz
2007-07-23 19:15 ` Ulrich Weigand
2007-07-23 21:25 ` Daniel Jacobowitz [this message]
2007-07-23 22:05 ` Ulrich Weigand
2007-07-23 22:54 ` Daniel Jacobowitz
2007-07-24 13:03 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070723191542.GA12138@caradoc.them.org \
--to=drow@false.org \
--cc=alex00882007@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox