From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8625 invoked by alias); 20 Jul 2007 15:28:25 -0000 Received: (qmail 8611 invoked by uid 22791); 20 Jul 2007 15:28:24 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 20 Jul 2007 15:28:05 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 17A5A982C3; Fri, 20 Jul 2007 15:28:00 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id C6BC59829C; Fri, 20 Jul 2007 15:27:59 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IBuOa-0002SP-UL; Fri, 20 Jul 2007 11:27:56 -0400 Date: Fri, 20 Jul 2007 15:30:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" Subject: Re: mips-tdep.c: Use is_mips16_addr() to test for the MIPS16 mode Message-ID: <20070720152756.GA9407@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , gdb-patches@sourceware.org, "Maciej W. Rozycki" References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00234.txt.bz2 On Fri, Jul 20, 2007 at 01:53:49PM +0100, Maciej W. Rozycki wrote: > Hello, > > We have a function to check whether an address of instruction implies the > MIPS16 mode or not. However mips_next_pc() checks that directly. Here is > a fix. No regressions for mipsisa32-sde-elf, with mips-sim-sde32/-EB and > mips-sim-sde32/-mips16/-EB. > > 2007-07-20 Maciej W. Rozycki > > * mips-tdep.c (mips_next_pc): Use is_mips16_addr() instead of > a direct test. > > OK to apply? OK. -- Daniel Jacobowitz CodeSourcery