From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Adjust SID-specific version of gdb_load to honor empty argument
Date: Thu, 19 Jul 2007 00:47:00 -0000 [thread overview]
Message-ID: <20070718174500.43b55667@ironwood.lan> (raw)
In-Reply-To: <20070713163226.29458e74@ironwood.lan>
Below is the patch that I ended up committing. This version differs
from the patch that I originally submitted in that this version removes
the call to gdb_unload. This change was suggested by Daniel in the
`Add another "Are you sure..."...' thread. I've tested it and it works
fine.
* config/sid.exp (gdb_load): Add test for empty argument. Adjust
return value to be compatible with gdb_run_cmd in lib/gdb.exp.
Remove call to gdb_unload.
Index: testsuite/config/sid.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/config/sid.exp,v
retrieving revision 1.9
diff -u -p -r1.9 sid.exp
--- testsuite/config/sid.exp 9 Jan 2007 17:59:08 -0000 1.9
+++ testsuite/config/sid.exp 19 Jul 2007 00:40:33 -0000
@@ -175,8 +175,10 @@ proc gdb_load { arg } {
global gdb_prompt
global retval
- gdb_unload
- if [gdb_file_cmd $arg] then { return -1 }
+ if { $arg != "" } {
+ if [gdb_file_cmd $arg] then { return -1 }
+ }
+
gdb_target_sid
send_gdb "load\n"
@@ -195,7 +197,7 @@ proc gdb_load { arg } {
if $verbose>1 then {
send_user "Loaded $arg into $GDB\n"
}
- set retval 1;
+ set retval 0;
}
-re "$gdb_prompt $" {
if $verbose>1 then {
prev parent reply other threads:[~2007-07-19 0:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 23:32 Kevin Buettner
2007-07-14 1:07 ` Daniel Jacobowitz
2007-07-19 0:47 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070718174500.43b55667@ironwood.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox