From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9670 invoked by alias); 14 Jul 2007 01:07:46 -0000 Received: (qmail 9651 invoked by uid 22791); 14 Jul 2007 01:07:45 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 14 Jul 2007 01:07:43 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 08D5A98299; Sat, 14 Jul 2007 01:07:42 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id C2E0098296; Sat, 14 Jul 2007 01:07:41 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1I9W6l-0005aR-In; Fri, 13 Jul 2007 21:07:39 -0400 Date: Sat, 14 Jul 2007 01:07:00 -0000 From: Daniel Jacobowitz To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Adjust SID-specific version of gdb_load to honor empty argument Message-ID: <20070714010739.GA21402@caradoc.them.org> Mail-Followup-To: Kevin Buettner , gdb-patches@sources.redhat.com References: <20070713163226.29458e74@ironwood.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070713163226.29458e74@ironwood.lan> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00206.txt.bz2 On Fri, Jul 13, 2007 at 04:32:26PM -0700, Kevin Buettner wrote: > Comments? > > In testsuite/ChangeLog: > > * config/sid.exp (gdb_load): Add test for empty argument. Adjust > return value to be compatible with gdb_run_cmd in lib/gdb.exp. Yes, this looks right to me. There's a lot of sid-specific bits sprinkled throughout the test harness; if you're feeling motivated (:-) the stuff I've done for gdbserver really should be flexible enough to work for sid too, but if it ain't broke... -- Daniel Jacobowitz CodeSourcery