From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [commit] mep-tdep.c: prologue analyzer update
Date: Fri, 13 Jul 2007 00:01:00 -0000 [thread overview]
Message-ID: <20070712170147.3586c1bd@ironwood.lan> (raw)
I've just committed the patch below. It fixes a gdb.base/break.exp
failure when using a gcc-4.x based compiler. (See the comment in the
patch for a full explanation.)
* mep-tdep.c (IS_BRA, BRA_DISP): New macros.
(mep_analyze_prologue): Add case for BRA instruction.
Index: mep-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mep-tdep.c,v
retrieving revision 1.5
diff -u -p -r1.5 mep-tdep.c
--- mep-tdep.c 16 Jun 2007 17:16:25 -0000 1.5
+++ mep-tdep.c 12 Jul 2007 23:52:31 -0000
@@ -1578,6 +1578,10 @@ mep_get_insn (CORE_ADDR pc, long *insn)
#define MOV_TARGET(i) (FIELD (i, 24, 4))
#define MOV_SOURCE(i) (FIELD (i, 20, 4))
+/* BRA disp12.align2 1011_dddd_dddd_ddd0 xxxx_xxxx_xxxx_xxxx */
+#define IS_BRA(i) (((i) & 0xf0010000) == 0xb0000000)
+#define BRA_DISP(i) (SFIELD (i, 17, 11) << 1)
+
/* This structure holds the results of a prologue analysis. */
struct mep_prologue
@@ -1806,6 +1810,19 @@ mep_analyze_prologue (CORE_ADDR start_pc
reg[rn] = pv_area_fetch (stack, addr, 4);
}
+ else if (IS_BRA (insn) && BRA_DISP (insn) > 0)
+ {
+ /* When a loop appears as the first statement as a function
+ body, gcc 4.x will use a BRA instruction to branch to the
+ loop condition checking code. This BRA instruction is
+ marked as part of the prologue. We therefore set next_pc
+ to this branch target and also stop the prologue scan.
+ The instructions at and beyond the branch target should
+ no longer be associated with the prologue. */
+ next_pc = pc + BRA_DISP (insn);
+ after_last_frame_setup_insn = next_pc;
+ break;
+ }
else
/* We've hit some instruction we don't know how to simulate.
Strictly speaking, we should set every value we're
next reply other threads:[~2007-07-13 0:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 0:01 Kevin Buettner [this message]
2007-07-13 3:17 ` Jim Blandy
2007-07-14 0:17 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070712170147.3586c1bd@ironwood.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox