From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10783 invoked by alias); 11 Jul 2007 19:41:53 -0000 Received: (qmail 10774 invoked by uid 22791); 11 Jul 2007 19:41:53 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 11 Jul 2007 19:41:50 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 225FB982EF for ; Wed, 11 Jul 2007 19:41:47 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id EA56E982C6 for ; Wed, 11 Jul 2007 19:41:46 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1I8i4D-0007Jk-Nx for gdb-patches@sourceware.org; Wed, 11 Jul 2007 15:41:41 -0400 Date: Wed, 11 Jul 2007 19:41:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [rfc] Detect dwarf address size mismatch Message-ID: <20070711194141.GA28114@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20070711141912.GA12298@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00178.txt.bz2 On Wed, Jul 11, 2007 at 12:27:29PM -0700, Jim Blandy wrote: > Would it make sense to move the check after the extended_op switch > altogether, and always use extended_len to advance line_ptr? This > would make GDB more robust against new extended opcodes. I thought about it; it might make sense to do this in the default case, but not in any of the handled cases, since they need to advance line_ptr anyway to read multiple items. -- Daniel Jacobowitz CodeSourcery