From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9243 invoked by alias); 8 Jul 2007 03:48:39 -0000 Received: (qmail 9235 invoked by uid 22791); 8 Jul 2007 03:48:39 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 08 Jul 2007 03:48:36 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id C7070982B8; Sun, 8 Jul 2007 03:48:34 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id A7E289829B; Sun, 8 Jul 2007 03:48:34 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1I7NlB-0004rl-79; Sat, 07 Jul 2007 23:48:33 -0400 Date: Sun, 08 Jul 2007 03:48:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [gdbserver/win32]: Ignore OUTPUT_DEBUG_STRING_EVENT events when remote is not connected. Message-ID: <20070708034833.GA18642@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <4690375A.6030009@portugalmail.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4690375A.6030009@portugalmail.pt> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00134.txt.bz2 On Sun, Jul 08, 2007 at 02:01:14AM +0100, Pedro Alves wrote: > Hi, > > OUTPUT_DEBUG_STRING_EVENT events can happen from after the inferior > is created, until it is stopped at the initial breakpoint, waiting > for gdb. The OUTPUT_DEBUG_STRING_EVENT handler doesn't currently > check if a remote connection is open before sending data, generating > annoying putpkt error logs to gdbserver's console. This > patch fixes it by simply ignoring those events when there isn't any > gdb connected yet. I didn't use server_wait, because this event > is also handled in win32_kill, outside of a wait. But don't you want to discard it if you're outside of a wait? I don't see how GDB would display them otherwise; remote_wait handles the 'O' response. -- Daniel Jacobowitz CodeSourcery