Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Changes to signed char and unsigned char handling
Date: Fri, 06 Jul 2007 21:34:00 -0000	[thread overview]
Message-ID: <20070706213408.GA5154@caradoc.them.org> (raw)
In-Reply-To: <ufy41ddor.fsf@gnu.org>

On Fri, Jul 06, 2007 at 01:33:24PM +0300, Eli Zaretskii wrote:
> > Date: Thu, 5 Jul 2007 09:54:02 -0400
> > From: Daniel Jacobowitz <drow@false.org>
> > 
> >  3.  Treat "char" as a character, but "unsigned char" and "signed char"
> >  as numbers
> 
> Didn't RMS object to this change?

His objection was to the original change, which is currently in HEAD,
to not print "unsigned char *" variables as strings.  It was not an
especially definitive objection; I think that this version is better
than the behavior of earlier versions of GDB, which would satisfy his
stated concern.

I'm willing to change my mind on the approach; that's why it's an RFC
:-)

> The changes for the manual are also okay, but I have a few
> comments/requests:

Thank you, as usual.  I will incorporate your suggestions.

> > @@ -5932,8 +5946,7 @@ displays you request manually using @cod
> >  specify the output format you prefer; in fact, @code{display} decides
> >  whether to use @code{print} or @code{x} depending on how elaborate your
> >  format specification is---it uses @code{x} if you specify a unit size,
> > -or one of the two formats (@samp{i} and @samp{s}) that are only
> > -supported by @code{x}; otherwise it uses @code{print}.
> > +the @samp{i} format, or the @samp{s} format; otherwise it uses @code{print}.
> 
> This change produces a sentence that is hard to parse:
> 
>   in fact, @code{display} decides
>   whether to use @code{print} or @code{x} depending on how elaborate your
>   format specification is---it uses @code{x} if you specify a unit size,
>   the @samp{i} format, or the @samp{s} format; otherwise it uses @code{print}.
> 
> The conditions under which `x' is used are described, but the
> conditions under which we use `i' or `s' are left unspecified.

We don't use `i' or `s'; the use of `i' or `s' in the user's format
specification causes `display' to behave like `examine' instead of
like `print'.  How is this?

   in fact, @code{display} decides
   whether to use @code{print} or @code{x} depending on your format
   specification---@code{display} uses @code{x} if you specify a unit size,
   the @samp{i} format, or the @samp{s} format; otherwise it uses @code{print}.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-07-06 21:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-05 13:54 Daniel Jacobowitz
2007-07-06 10:33 ` Eli Zaretskii
2007-07-06 21:34   ` Daniel Jacobowitz [this message]
2007-07-07 10:04     ` Eli Zaretskii
2007-07-07 17:06       ` Daniel Jacobowitz
2007-07-06 23:26   ` Nick Roberts
2007-07-06 23:46     ` Daniel Jacobowitz
2007-08-25  1:18 ` Daniel Jacobowitz
2007-08-25 10:19   ` Eli Zaretskii
2007-09-03 17:53   ` Daniel Jacobowitz
2007-09-04 13:58     ` Joel Brobecker
2007-09-04 22:40     ` Mark Kettenis
2007-09-05  0:51       ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070706213408.GA5154@caradoc.them.org \
    --to=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox