On Tuesday 03 July 2007 21:13, Daniel Jacobowitz wrote:
> On Mon, Jun 18, 2007 at 02:42:59PM +0400, Vladimir Prus wrote:
> > 
> > The attached patch is a revised, and updated for mainline,
> > version of my earlier patch to add -var-info-path-expression.
> > The review of the previous version is at:
> > 
> > 	http://article.gmane.org/gmane.comp.gdb.patches/32582
> > 
> > and asks for: 
> > 
> > 	1. _() in some places.
> > 	2. Not using of name of gdb function in mi error messages
> > 	3. Points that path_expr != NULL implies it's not a root
> > 	varobj.
> > 
> > Those changes were made.
> 
> Is this the right version of the patch?  I was going to say it was OK,
> with documentation, and a few small changes - but that's the list of
> small changes above.  

Oops. I've forgotten to commit said changes to my local repo, from
where patches are generated. Here's updated patch.

> Anyway, other than that and some comment formatting, it looks fine to me.

What kind of formatting? Do you think you can indicate what to fix so that
I can fix it on my own without you pinpointing every problem. Two spaces again,
or something else?

- Volodya