From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9443 invoked by alias); 3 Jul 2007 17:58:51 -0000 Received: (qmail 9433 invoked by uid 22791); 3 Jul 2007 17:58:51 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 03 Jul 2007 17:58:48 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 33F43982C4; Tue, 3 Jul 2007 17:58:46 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 0899A9829D; Tue, 3 Jul 2007 17:58:46 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1I5mdj-0004Vi-On; Tue, 03 Jul 2007 13:58:15 -0400 Date: Tue, 03 Jul 2007 17:58:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: -var-info-path-expression Message-ID: <20070703175815.GK2868@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200706181442.59867.vladimir@codesourcery.com> <20070703171352.GG2868@caradoc.them.org> <200707032151.20383.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200707032151.20383.vladimir@codesourcery.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00075.txt.bz2 On Tue, Jul 03, 2007 at 09:51:19PM +0400, Vladimir Prus wrote: > > Anyway, other than that and some comment formatting, it looks fine to me. > > What kind of formatting? Do you think you can indicate what to fix so that > I can fix it on my own without you pinpointing every problem. Two spaces again, > or something else? Yeah, that and a final period in the comment above varobj_get_path_expr. I didn't point out each one, because honestly I'm trying to be less picky about that sort of thing - it's not as if the comments weren't clear anyway. This version is OK to commit, but please wait until you have a doc patch and maybe a testcase to go with it. Thanks for being patient. -- Daniel Jacobowitz CodeSourcery