From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19370 invoked by alias); 3 Jul 2007 17:14:28 -0000 Received: (qmail 19360 invoked by uid 22791); 3 Jul 2007 17:14:28 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 03 Jul 2007 17:14:25 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 6DA409829E; Tue, 3 Jul 2007 17:14:23 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 342309829D; Tue, 3 Jul 2007 17:14:23 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1I5lwm-0003yd-QX; Tue, 03 Jul 2007 13:13:52 -0400 Date: Tue, 03 Jul 2007 17:14:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: -var-info-path-expression Message-ID: <20070703171352.GG2868@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200706181442.59867.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200706181442.59867.vladimir@codesourcery.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00070.txt.bz2 On Mon, Jun 18, 2007 at 02:42:59PM +0400, Vladimir Prus wrote: > > The attached patch is a revised, and updated for mainline, > version of my earlier patch to add -var-info-path-expression. > The review of the previous version is at: > > http://article.gmane.org/gmane.comp.gdb.patches/32582 > > and asks for: > > 1. _() in some places. > 2. Not using of name of gdb function in mi error messages > 3. Points that path_expr != NULL implies it's not a root > varobj. > > Those changes were made. Is this the right version of the patch? I was going to say it was OK, with documentation, and a few small changes - but that's the list of small changes above. For instance: > + if (argc != 1) > + error ("mi_cmd_var_info_path_expression: Usage: NAME."); And these two that disagree: > - var->name = savestring (expression, strlen (expression)); > + expr_len = strlen (expression); > + var->name = savestring (expression, expr_len); > + /* For a root var, the name and the expr are the same. */ > + var->path_expr = savestring (expression, expr_len); > + if (var->path_expr != NULL) > + return var->path_expr; > + else if (is_root_p (var)) > + return var->name; > + else > + { > + return (*var->root->lang->path_expr_of_child) (var); > + } Anyway, other than that and some comment formatting, it looks fine to me. -- Daniel Jacobowitz CodeSourcery