From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10822 invoked by alias); 3 Jul 2007 12:17:28 -0000 Received: (qmail 10809 invoked by uid 22791); 3 Jul 2007 12:17:26 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 03 Jul 2007 12:17:23 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id l63CHKjk100924 for ; Tue, 3 Jul 2007 12:17:20 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l63CHKHs1704116 for ; Tue, 3 Jul 2007 14:17:20 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l63CHJVG002938 for ; Tue, 3 Jul 2007 14:17:20 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l63CHJQg002934; Tue, 3 Jul 2007 14:17:19 +0200 Message-Id: <200707031217.l63CHJQg002934@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 3 Jul 2007 14:17:19 +0200 Subject: Re: [PING 2] [rfc]: Framework for looking up multiply defined global symbols in shared libraries To: deuling@de.ibm.com (Markus Deuling) Date: Tue, 03 Jul 2007 12:17:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com (Joel Brobecker), gdb-patches@sourceware.org (GDB Patches), drow@false.org (Daniel Jacobowitz), kevinb@redhat.com (Kevin Buettner), eliz@gnu.org In-Reply-To: <4689CA65.6040908@de.ibm.com> from "Markus Deuling" at Jul 03, 2007 06:02:45 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00061.txt.bz2 Markus Deuling wrote: > * cp-namespace.c (lookup_symbol_file): Add block to > lookup_symbol_global call. > * Makefile.in (solist_h): Add dependency on symtab header. > (symtab.o): Add dependency on solist header. > * solib.c (solib_global_lookup): New function. > * solib-svr4.c (scan_dyntag): Likewise. > (elf_locate_base): Call helper routine scan_dyntag. > (elf_lookup_lib_symbol): New function. > (_initialize_svr4_solib): Add elf_lookup_lib_symbol to svr4_so_ops. > * solist.h (symtab.h): New include. > (lookup_lib_global_symbol): New prototype. I guess this should read: (struct target_so_ops): New member lookup_lib_global_symbol. > (solib_global_lookup): Likewise. > * symtab.c: New include solist.h. > (lookup_objfile_from_block): New function. > (lookup_global_symbol_from_objfile): New function. > (basic_lookup_symbol_nonlocal): Add block to lookup_symbol_global call. > (lookup_symbol_global): Call library-specific lookup procedure. > * symtab.h (lookup_global_symbol_from_objfile): New prototype. > * gdb.base/libmd.c: New file (testcase multiple symbol lookup). > * gdb.base/libmd.h: Likewise. > * gdb.base/solib_symbol.c: Likewise. > * gdb.base/solib_symbol.exp: Likewise. And those file names have changed in the latest version: * gdb.base/solib-symbol.exp: New file (testcase multiple symbol lookup). * gdb.base/solib-symbol-lib.c: Likewise. * gdb.base/solib-symbol-main.c: Likewise. I've committed the patch with the above ChangeLog changes now. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com