From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23192 invoked by alias); 3 Jul 2007 01:12:23 -0000 Received: (qmail 23184 invoked by uid 22791); 3 Jul 2007 01:12:22 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 03 Jul 2007 01:12:20 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id E0DA39829C; Tue, 3 Jul 2007 01:12:18 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 58F889817B; Tue, 3 Jul 2007 01:12:18 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1I5Wvj-0007AM-KF; Mon, 02 Jul 2007 21:11:47 -0400 Date: Tue, 03 Jul 2007 01:12:00 -0000 From: Daniel Jacobowitz To: msnyder@sonic.net Cc: gdb-patches@sourceware.org, gaius@glam.ac.uk Subject: Re: [RFC] logic change in m2-valprint.c Message-ID: <20070703011147.GA26350@caradoc.them.org> Mail-Followup-To: msnyder@sonic.net, gdb-patches@sourceware.org, gaius@glam.ac.uk References: <16087.12.7.175.2.1183076995.squirrel@webmail.sonic.net> <20070701154831.GE10872@caradoc.them.org> <004a01c7bbf8$16a2ccc0$677ba8c0@sonic.net> <20070701160224.GH10872@caradoc.them.org> <9624.12.7.175.2.1183421112.squirrel@webmail.sonic.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9624.12.7.175.2.1183421112.squirrel@webmail.sonic.net> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00045.txt.bz2 On Mon, Jul 02, 2007 at 05:05:12PM -0700, Michael Snyder wrote: > is nowhere else for it to be set false), and there is no second > time -- we will never enter this block again because we will set > "element_seen" to true (and there is nowhere else for it to be > set false again). > > Was that clear? Clear, but not right. 152 element_seen = 0; On entry, empty_set = 1 and element_seen = 0. We see an element, which causes us set empty_set = 0 and element_seen = 1. Then we see a clear bit in the set and set element_seen to 0 and not change empty_set. Then we see a set bit, and element_seen == 0 with empty_set == 0. We print the comma. I would test it, but I don't have an M-2 compiler and the expression parser can't create sets. Am I missing something? -- Daniel Jacobowitz CodeSourcery