From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10593 invoked by alias); 2 Jul 2007 18:24:39 -0000 Received: (qmail 10584 invoked by uid 22791); 2 Jul 2007 18:24:38 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 02 Jul 2007 18:24:32 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id l62IOSEG1236518 for ; Mon, 2 Jul 2007 18:24:28 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l62IOSvl2007244 for ; Mon, 2 Jul 2007 20:24:28 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l62IORa9025950 for ; Mon, 2 Jul 2007 20:24:28 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l62IORIn025947; Mon, 2 Jul 2007 20:24:27 +0200 Message-Id: <200707021824.l62IORIn025947@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 2 Jul 2007 20:24:27 +0200 Subject: Re: [PING 2] [rfc]: Framework for looking up multiply defined global symbols in shared libraries To: deuling@de.ibm.com (Markus Deuling) Date: Mon, 02 Jul 2007 18:24:00 -0000 From: "Ulrich Weigand" Cc: deuling@de.ibm.com (Markus Deuling), brobecker@adacore.com (Joel Brobecker), gdb-patches@sourceware.org (GDB Patches), drow@false.org (Daniel Jacobowitz), kevinb@redhat.com (Kevin Buettner), eliz@gnu.org In-Reply-To: <4683D468.4090808@de.ibm.com> from "Markus Deuling" at Jun 28, 2007 05:31:52 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00035.txt.bz2 Markus Deuling wrote: > Ok, I renamed the testsuite files to solib-symbol.exp and solib-symbol-{main,lib}.c The header has been removed. > > I also changed the NEWS entry. Eli, is this ok ? Thanks, Markus. > @@ -2572,7 +2572,7 @@ > $(objfiles_h) $(exceptions_h) $(gdbcore_h) $(command_h) $(target_h) \ > $(frame_h) $(gdb_regex_h) $(inferior_h) $(environ_h) $(language_h) \ > $(gdbcmd_h) $(completer_h) $(filenames_h) $(exec_h) $(solist_h) \ > - $(observer_h) $(readline_h) > + $(observer_h) $(readline_h) $(objfiles_h) > solib-frv.o: solib-frv.c $(defs_h) $(gdb_string_h) $(inferior_h) \ > $(gdbcore_h) $(solist_h) $(frv_tdep_h) $(objfiles_h) $(symtab_h) \ > $(language_h) $(command_h) $(gdbcmd_h) $(elf_frv_h) $(solib_h) This part of the Makefile.in change does not appear to be necessary -- there is no corresponding source code change to the solib-svr4.c file in the patch. Please verify this, and re-send the patch with an up-to-date ChangeLog entry -- I'll check it in then. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com