From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14529 invoked by alias); 28 Jun 2007 12:44:52 -0000 Received: (qmail 14517 invoked by uid 22791); 28 Jun 2007 12:44:50 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate8.de.ibm.com (HELO mtagate8.de.ibm.com) (195.212.29.157) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 28 Jun 2007 12:44:46 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5SCih7p447888 for ; Thu, 28 Jun 2007 12:44:43 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5SCihj81527856 for ; Thu, 28 Jun 2007 14:44:43 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5SCigJF023036 for ; Thu, 28 Jun 2007 14:44:43 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l5SCigKr023030; Thu, 28 Jun 2007 14:44:42 +0200 Message-Id: <200706281244.l5SCigKr023030@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 28 Jun 2007 14:44:42 +0200 Subject: Re: [PING 2] [rfc]: Framework for looking up multiply defined global symbols in shared libraries To: deuling@de.ibm.com (Markus Deuling) Date: Thu, 28 Jun 2007 15:32:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com (Joel Brobecker), gdb-patches@sourceware.org (GDB Patches), drow@false.org (Daniel Jacobowitz), kevinb@redhat.com (Kevin Buettner), eliz@gnu.org In-Reply-To: <46816460.1080103@de.ibm.com> from "Markus Deuling" at Jun 26, 2007 09:09:20 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00490.txt.bz2 Markus Deuling wrote: > diff -urN src/gdb/NEWS dev/gdb/NEWS > --- src/gdb/NEWS 2007-06-21 19:00:43.000000000 +0200 > +++ dev/gdb/NEWS 2007-06-26 21:06:05.000000000 +0200 > @@ -3,6 +3,9 @@ > > *** Changes since GDB 6.6 > > +* New framework for looking up multiply defined global symbols from shared > + libraries. > + It's up to Eli to approve NEWS entries, but it has been my understanding that NEWS should be about user-visible features, not internal infrastructure changes. I'd reword to this something like: "When looking up multiply-defined global symbols, GDB will now prefer the symbol definition in the current shared library if it was built using the -Bsymbolic linker option." I've noticed a couple of minor issues in the test case: > diff -urN src/gdb/testsuite/gdb.base/libmd.c dev/gdb/testsuite/gdb.base/libmd.c What is libmd supposed to stand for? > --- src/gdb/testsuite/gdb.base/libmd.c 1970-01-01 01:00:00.000000000 +0100 > +++ dev/gdb/testsuite/gdb.base/libmd.c 2007-06-26 21:03:32.000000000 +0200 > +extern void foo(); This doesn't appear to be necessary; foo isn't even referred to ... +void foo2 (); Likewise. > diff -urN src/gdb/testsuite/gdb.base/libmd.h dev/gdb/testsuite/gdb.base/libmd.h > --- src/gdb/testsuite/gdb.base/libmd.h 1970-01-01 01:00:00.000000000 +0100 > +++ dev/gdb/testsuite/gdb.base/libmd.h 2007-06-26 21:03:32.000000000 +0200 In fact, this whole header file looks unnecessary to me. > diff -urN src/gdb/testsuite/gdb.base/solib_symbol.c dev/gdb/testsuite/gdb.base/solib_symbol.c > --- src/gdb/testsuite/gdb.base/solib_symbol.c 1970-01-01 01:00:00.000000000 +0100 > +++ dev/gdb/testsuite/gdb.base/solib_symbol.c 2007-06-26 21:03:32.000000000 +0200 > +extern void foo(); > +#include > +#include "libmd.h" > + > +extern void foo(); Here we have the declaration three times ;-) Once is enough ... Otherwise, this looks OK to me now. -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com