From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6057 invoked by alias); 27 Jun 2007 00:13:20 -0000 Received: (qmail 6040 invoked by uid 22791); 27 Jun 2007 00:13:19 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 27 Jun 2007 00:13:17 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5R0DE8n495886; Wed, 27 Jun 2007 00:13:14 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5R0DEM31818850; Wed, 27 Jun 2007 02:13:14 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5R0DDkE030372; Wed, 27 Jun 2007 02:13:13 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l5R0DDii030369; Wed, 27 Jun 2007 02:13:13 +0200 Message-Id: <200706270013.l5R0DDii030369@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 27 Jun 2007 02:13:13 +0200 Subject: Re: [3/3] Remove deprecated_register_gdbarch_swap infrastructure To: insight@sourceware.org Date: Wed, 27 Jun 2007 01:10:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <46815309.331600D9@dessent.net> from "Brian Dessent" at Jun 26, 2007 10:55:21 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00477.txt.bz2 Brian Dessent wrote: > Insight is still a user of deprecated_register_gdbarch_swap, so now it's > broken. What's the proper replacement for the following - > > int > Gdbtk_Register_Init (Tcl_Interp *interp) > { > Tcl_CreateObjCommand (interp, "gdb_reginfo", gdbtk_call_wrapper, > gdb_register_info, NULL); > > /* Register/initialize any architecture specific data */ > setup_architecture_data (); > > deprecated_register_gdbarch_swap (&old_regs, sizeof (old_regs), NULL); > deprecated_register_gdbarch_swap (®format, sizeof (regformat), > NULL); > deprecated_register_gdbarch_swap (®type, sizeof (regtype), NULL); > deprecated_register_gdbarch_swap (NULL, 0, setup_architecture_data); > > return TCL_OK; > } There's no direct replacement. You'd have to eliminate those global variables (old_regs, regformat, regtype), and replace them by something that explicitly takes the architecture into account. I've actually never looked at Insight before. Where's that code located? Bye, -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com