From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16248 invoked by alias); 25 Jun 2007 18:17:52 -0000 Received: (qmail 16238 invoked by uid 22791); 25 Jun 2007 18:17:51 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 25 Jun 2007 18:17:49 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5PIHkZK109924 for ; Mon, 25 Jun 2007 18:17:46 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5PIHkRw1786020 for ; Mon, 25 Jun 2007 20:17:46 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5PIHjb1014157 for ; Mon, 25 Jun 2007 20:17:45 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l5PIHjCv014129; Mon, 25 Jun 2007 20:17:45 +0200 Message-Id: <200706251817.l5PIHjCv014129@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 25 Jun 2007 20:17:43 +0200 Subject: Re: [PATCH] Fixes problem setting breakpoint in dynamic loader To: drow@false.org (Daniel Jacobowitz) Date: Mon, 25 Jun 2007 21:28:00 -0000 From: "Ulrich Weigand" Cc: joseph@codesourcery.com (Joseph S. Myers), bauerman@br.ibm.com (Thiago Jung Bauermann), gdb-patches@sourceware.org (gdb-patches ml) In-Reply-To: <20070620131524.GA21190@caradoc.them.org> from "Daniel Jacobowitz" at Jun 20, 2007 09:15:24 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00448.txt.bz2 Daniel Jacobowitz wrote: One minor issue I just noticed: > Index: gdbserver/remote-utils.c > =================================================================== > --- gdbserver/remote-utils.c (revision 174465) > +++ gdbserver/remote-utils.c (working copy) > @@ -1063,15 +1063,33 @@ look_up_one_symbol (const char *name, CO > + decode_m_packet (&own_buf[1], &mem_addr, &len); This results in a warning as the last parameter to decode_m_packet is supposed to be "unsigned int *", but "len" is signed int. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com