From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13843 invoked by alias); 25 Jun 2007 21:28:03 -0000 Received: (qmail 13833 invoked by uid 22791); 25 Jun 2007 21:28:02 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 25 Jun 2007 21:28:00 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l5PLRwk3019549 for ; Mon, 25 Jun 2007 17:27:58 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l5PLRwDS016774 for ; Mon, 25 Jun 2007 17:27:58 -0400 Received: from ironwood.lan (vpn-14-25.rdu.redhat.com [10.11.14.25]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l5PLRv8B006838 for ; Mon, 25 Jun 2007 17:27:57 -0400 Date: Mon, 25 Jun 2007 21:48:00 -0000 From: Kevin Buettner To: gdb-patches@sources.redhat.com Subject: Re: [PING] [rfc]: Framework for looking up multiply defined global symbols in shared libraries Message-ID: <20070625142757.776e3ad6@ironwood.lan> In-Reply-To: <4664DC23.70903@de.ibm.com> References: <200705312124.l4VLO1qU019395@d12av02.megacenter.de.ibm.com> <4664DC23.70903@de.ibm.com> X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.10.4; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00449.txt.bz2 On Tue, 05 Jun 2007 05:44:35 +0200 Markus Deuling wrote: > Is this ok to commit? > > ChangeLog: > > * cp-namespace.c (lookup_symbol_file): Add block to > lookup_symbol_global call. > * Makefile.in (solist_h): Add dependency on symtab header. > (solib.o): Add dependency on objfiles header. > (symtab.o): Add dependency on solist header. > * solib.c (solib_global_lookup): New function. > * solib-svr4.c (scan_dyntag): Likewise. > (elf_locate_base): Call helper routine scan_dyntag. > (elf_lookup_lib_symbol): New function. > (_initialize_svr4_solib): Add elf_lookup_lib_symbol to svr4_so_ops. > * solist.h (symtab.h): New include. > (lookup_lib_global_symbol): New prototype. > (solib_global_lookup): Likewise. > * symtab.c: New include solist.h. > (lookup_objfile_from_block): New function. > (lookup_global_symbol_from_objfile): New function. > (basic_lookup_symbol_nonlocal): Add block to lookup_symbol_global call. > (lookup_symbol_global): Call library-specific lookup procedure. > * symtab.h (lookup_global_symbol_from_objfile): New prototype. > * gdb.base/libmd.c: New file (testcase multiple symbol lookup). > * gdb.base/libmd.h: Likewise. > * gdb.base/solib_symbol.c: Likewise. > * gdb.base/solib_symbol.exp: Likewise. Your changes to solib.c, solib-svr.c, and solist.h are approved. Kevin