From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20102 invoked by alias); 19 Jun 2007 16:39:55 -0000 Received: (qmail 20093 invoked by uid 22791); 19 Jun 2007 16:39:54 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 19 Jun 2007 16:39:51 +0000 Received: (qmail 9563 invoked from network); 19 Jun 2007 16:39:48 -0000 Received: from unknown (HELO h38.net64.aknet.ru) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 19 Jun 2007 16:39:48 -0000 From: Vladimir Prus To: Eli Zaretskii Subject: Re: ColdFire/fido support Date: Tue, 19 Jun 2007 16:39:00 -0000 User-Agent: KMail/1.9.1 Cc: drow@false.org, schwab@suse.de, gdb-patches@sources.redhat.com References: <200705051337.02114.vladimir@codesourcery.com> <200706152305.25699.vladimir@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200706192039.36897.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00368.txt.bz2 On Saturday 16 June 2007 14:20, Eli Zaretskii wrote: > > From: Vladimir Prus > > Date: Fri, 15 Jun 2007 23:05:25 +0400 > > Cc: Andreas Schwab , gdb-patches@sources.redhat.com, Eli Zaretskii > > > > Does this doco patch look good? > > It's okay, but I'd prefer to convert the two subsections--the old ARM > one and the new one you wrote--into @node's, and add a menu in their > parent. With two targets (and more to come, I presume), it is no > longer a good idea to hide those subsections from the menu traversing > commands of an Info reader. Okay, I'll do this. > > +An M68K target is required to have either the > > +@samp{org.gnu.gdb.m68k.core} feature or the > > +@samp{org.gnu.gdb.coldfire.core} feature or the > > +@samp{org.gnu.gdb.fido.core} feature. Which feature is present > > +determines which flavour of m68k is used. The present feature > > +should contain registers @samp{d0} through @samp{d7}, > > +@samp{a0} through @samp{a5}, @samp{fp}, @samp{sp}, @samp{ps} and > > +@samp{pc}. > > + > > +The @samp{org.gnu.gdb.coldfire.fp} feature is optional. If present, it > > +should contain registers @samp{fp0} through @samp{fp7}, > > +@samp{fpcontrol}, @samp{fpstatus} and @samp{fpiaddr}. > > Isn't it better to use an @itemize list here? How about the following > rewording: > > @node M68K Features > @subsection M68K Features > @cindex target descriptions, M68K features > > An M68K target can have either one of the following features: > @itemize @bullet{} > @item > @samp{org.gnu.gdb.m68k.core} > @itemx > @samp{org.gnu.gdb.coldfire.core} > @itemx > @samp{org.gnu.gdb.fido.core} > The feature that is present determines which flavor of m86k is > used. The feature that is present should contain registers > @samp{d0} through @samp{d7}, @samp{a0} through @samp{a5}, @samp{fp}, > @samp{sp}, @samp{ps} and @samp{pc}. > > @item > @samp{org.gnu.gdb.coldfire.fp} > This feature is optional. If present, it should contain registers > @samp{fp0} through @samp{fp7}, @samp{fpcontrol}, @samp{fpstatus} and > @samp{fpiaddr}. > @end itemize When I try copy-pasting this, I get: @itemx not meaningful inside `itemize' block. It also seems that the general structure says that both .*core* and coldfire.fp are optional, while I meant to say that one of .*core.* is required, while coldfire.fp is optional. > > Finally, please use the US English variant of spelling: "flavor", not > "flavour". Ok. - Volodya