Re: ColdFire/fido support

Daniel Jacobowitz
2007-06-15T14:47:53Z

On Fri, Jun 15, 2007 at 02:17:24PM +0400, Vladimir Prus wrote:
> On Tuesday 12 June 2007 17:38, Daniel Jacobowitz wrote:
>
> > > I suppose I can add file-based detection for fido, just like it's done for coldfire,
> > > but I don't think removing XML-based detection is right. What do you think?
> >
> > Right, sorry - I know what I meant to say, but I didn't say it.
> >
> > Float return behavior is not a property of the target at all; it's a
> > property of the compiler options used. decr_pc_after_break is a
> > target property, though, so we should trust the target. This isn't
> > important, though, so feel free to commit without changing this. If
> > it causes any problems we can clean it up later.
>
> Ok, excellent.
>
> I attach a patch that differs only by non-taking of address of builtin_types. OK?

I also wrote:

> This is mostly OK. Please add a Makefile.in update for the new
> #include. Also, we've added XML support for another target. So it
> needs a new section in the manual describing which targets support
> XML registers, and which registers are required.

It does still need those. Other than that it's OK.

--
Daniel Jacobowitz
CodeSourcery