Re: ColdFire/fido support

Vladimir Prus
2007-06-15T19:05:34Z

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

On Friday 15 June 2007 18:47, Daniel Jacobowitz wrote:
> On Fri, Jun 15, 2007 at 02:17:24PM +0400, Vladimir Prus wrote:
> > On Tuesday 12 June 2007 17:38, Daniel Jacobowitz wrote:
> >
> > > > I suppose I can add file-based detection for fido, just like it's done for coldfire,
> > > > but I don't think removing XML-based detection is right. What do you think?
> > >
> > > Right, sorry - I know what I meant to say, but I didn't say it.
> > >
> > > Float return behavior is not a property of the target at all; it's a
> > > property of the compiler options used. decr_pc_after_break is a
> > > target property, though, so we should trust the target. This isn't
> > > important, though, so feel free to commit without changing this. If
> > > it causes any problems we can clean it up later.
> >
> > Ok, excellent.
> >
> > I attach a patch that differs only by non-taking of address of builtin_types. OK?
>
> I also wrote:
>
> > This is mostly OK. Please add a Makefile.in update for the new
> > #include. Also, we've added XML support for another target. So it
> > needs a new section in the manual describing which targets support
> > XML registers, and which registers are required.
>
> It does still need those. Other than that it's OK.

Does this doco patch look good?

- Volodya

[-- Attachment #2: docs.diff --]
[-- Type: text/x-diff, Size: 953 bytes --]

--- gdb.texinfo (revision 4281)
+++ gdb.texinfo (local)
@@ -25751,6 +25751,22 @@ it should contain at least registers @sa
@samp{wCGR0} through @samp{wCGR3}. The @samp{wCID}, @samp{wCon},
@samp{wCSSF}, and @samp{wCASF} registers are optional.

+@subsection M68K Features
+@cindex target descriptions, M68K features
+
+An M68K target is required to have either the
+@samp{org.gnu.gdb.m68k.core} feature or the
+@samp{org.gnu.gdb.coldfire.core} feature or the
+@samp{org.gnu.gdb.fido.core} feature. Which feature is present
+determines which flavour of m68k is used. The present feature
+should contain registers @samp{d0} through @samp{d7},
+@samp{a0} through @samp{a5}, @samp{fp}, @samp{sp}, @samp{ps} and
+@samp{pc}.
+
+The @samp{org.gnu.gdb.coldfire.fp} feature is optional. If present, it
+should contain registers @samp{fp0} through @samp{fp7},
+@samp{fpcontrol}, @samp{fpstatus} and @samp{fpiaddr}.
+
@include gpl.texi

@raisesections