From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19858 invoked by alias); 18 Jun 2007 23:28:51 -0000 Received: (qmail 19848 invoked by uid 22791); 18 Jun 2007 23:28:50 -0000 X-Spam-Check-By: sourceware.org Received: from pool-71-248-179-245.bstnma.fios.verizon.net (HELO cgf.cx) (71.248.179.245) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 18 Jun 2007 23:28:48 +0000 Received: by cgf.cx (Postfix, from userid 201) id F0C1313C0AC; Mon, 18 Jun 2007 19:28:46 -0400 (EDT) Date: Mon, 18 Jun 2007 23:28:00 -0000 From: Christopher Faylor To: Ulrich Weigand , Pedro Alves , gdb-patches@sourceware.org Subject: Re: For example only, updated Windows DLL support and gdbserver DLL support Message-ID: <20070618232846.GA20090@trixie.casa.cgf.cx> Mail-Followup-To: Ulrich Weigand , Pedro Alves , gdb-patches@sourceware.org References: <20070618150816.GA24037@caradoc.them.org> <20070618210728.GB1813@ednor> <20070618211213.GA1110@caradoc.them.org> <4676FEEC.2010008@portugalmail.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4676FEEC.2010008@portugalmail.pt> User-Agent: Mutt/1.5.15 (2007-04-06) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00359.txt.bz2 On Mon, Jun 18, 2007 at 10:53:48PM +0100, Pedro Alves wrote: > Daniel Jacobowitz wrote: >> On Mon, Jun 18, 2007 at 05:07:28PM -0400, Christopher Faylor wrote: >>> I have no objections to this with two exceptions: >>> >>> - You use #ifdef __CYGWIN__ . That would be the only place in the file >>> where that is used. I don't see any reason for this unless your patch >>> is also going to allow native Windows support. If that is the case, >>> then maybe that part should be provided separately. >>> >>> - You seemed to have gratuitously pulled out the code which deals with >>> cygwin exceptions into a separate function. I don't think this has >>> anything to do with solibs and probably shouldn't be part of any >>> final patch. >> Pedro, what do you remember about these? At least, I don't _think_ it >> was me... > > Guilty as charged. > > The __CYGWIN__ came from copy/pasting from the gdbserver side of the > patch, where it is needed. It can be easily removed. Ok. > The gratuitousness is only apparent. Notice that the > cygwin_load_start/cygwin_load_end calculation moved from the > old solib_symbols_add into that new ignore_access_violation_p > function and now uses the master_so_list () to get at cygwin1.dll. > As I was touching the code, (and I was finding myself reindenting > that big comment, ) I thought of moving it out of handle_exception > to make it cleaner. You're right. I should have looked closer. It wasn't a gratuitous change and I agree that moving it into its own function makes sense. Ship it! cgf