From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26790 invoked by alias); 18 Jun 2007 21:07:29 -0000 Received: (qmail 26761 invoked by uid 22791); 18 Jun 2007 21:07:27 -0000 X-Spam-Check-By: sourceware.org Received: from pool-71-248-179-245.bstnma.fios.verizon.net (HELO cgf.cx) (71.248.179.245) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 18 Jun 2007 21:07:22 +0000 Received: by cgf.cx (Postfix, from userid 201) id 53F482B352; Mon, 18 Jun 2007 17:07:28 -0400 (EDT) Date: Mon, 18 Jun 2007 21:07:00 -0000 From: Christopher Faylor To: Pedro Alves , Ulrich Weigand , gdb-patches@sourceware.org Subject: Re: For example only, updated Windows DLL support and gdbserver DLL support Message-ID: <20070618210728.GB1813@ednor> Mail-Followup-To: Pedro Alves , Ulrich Weigand , gdb-patches@sourceware.org References: <20070618150816.GA24037@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070618150816.GA24037@caradoc.them.org> User-Agent: Mutt/1.5.15 (2007-04-06) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00351.txt.bz2 On Mon, Jun 18, 2007 at 11:08:16AM -0400, Daniel Jacobowitz wrote: >Here's the latest version of my Windows support patch to go with the >previous shared library event support. Most of this is originally >Pedro's work. It includes native GDB and remote gdbserver support, >and also fixes a bug in native support where symbols for shared >libraries were not being loaded. I have no objections to this with two exceptions: - You use #ifdef __CYGWIN__ . That would be the only place in the file where that is used. I don't see any reason for this unless your patch is also going to allow native Windows support. If that is the case, then maybe that part should be provided separately. - You seemed to have gratuitously pulled out the code which deals with cygwin exceptions into a separate function. I don't think this has anything to do with solibs and probably shouldn't be part of any final patch. cgf