From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24304 invoked by alias); 15 Jun 2007 23:07:08 -0000 Received: (qmail 24104 invoked by uid 22791); 15 Jun 2007 23:07:07 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 15 Jun 2007 23:07:05 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5FN73ef188726 for ; Fri, 15 Jun 2007 23:07:03 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5FN72cf3813540 for ; Sat, 16 Jun 2007 01:07:02 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5FN72BD031590 for ; Sat, 16 Jun 2007 01:07:02 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l5FN72xa031587; Sat, 16 Jun 2007 01:07:02 +0200 Message-Id: <200706152307.l5FN72xa031587@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Sat, 16 Jun 2007 01:07:02 +0200 Subject: Re: [rfc] Remove macro DEPRECATED_EXTRACT_STRUCT_VALUE_ADDRES To: mark.kettenis@xs4all.nl (Mark Kettenis) Date: Fri, 15 Jun 2007 23:07:00 -0000 From: "Ulrich Weigand" Cc: deuling@de.ibm.com, gdb-patches@sourceware.org In-Reply-To: <200706152057.l5FKvaO9011259@brahms.sibelius.xs4all.nl> from "Mark Kettenis" at Jun 15, 2007 10:57:36 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00306.txt.bz2 Mark Kettenis wrote: > > Date: Wed, 13 Jun 2007 21:19:11 +0200 > > From: Markus Deuling > > > > Hello, > > > > this patch removes DEPRECATED_EXTRACT_STRUCT_VALUE_ADDRES from gdbarch.sh. This macro hasn't been > > used anywhere anymore. Build and tested on x86. > > > > ChangeLog: > > * gdbarch.sh (DEPRECATED_EXTRACT_STRUCT_VALUE_ADDRES): Remove. > > * gdbarch.c, gdbarch.h: Regenerate. > > > > Is this ok to commit ? > > Last time I looked, there was still stuff using this. Are you sure? There is no *caller* of this gdbarch callback left anywhere. However, a number of targets (sh/sh64/frv/ia64) still install this callback. Those functions are all dead code now, and should be removed as well. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com